MTU option not set in ironic-inspector dnsmasq.conf

Bug #1845487 reported by Harald Jensås on 2019-09-26
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
puppet-ironic
Undecided
Harald Jensås
tripleo
Medium
Harald Jensås

Bug Description

The MTU option is not set for the ironic-inspector dnsmasq instace. It should be configurable, with a default 1500.

Changed in puppet-ironic:
assignee: nobody → Harald Jensås (harald-jensas)

Fix proposed to branch: master
Review: https://review.opendev.org/685054

Changed in puppet-ironic:
status: New → In Progress

Fix proposed to branch: master
Review: https://review.opendev.org/685065

Changed in tripleo:
assignee: nobody → Harald Jensås (harald-jensas)
status: New → In Progress
Changed in tripleo:
milestone: none → train-rc1
importance: Undecided → Medium

Reviewed: https://review.opendev.org/685054
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=03550bc8c8d05583e76c335c465684cec6d55093
Submitter: Zuul
Branch: master

commit 03550bc8c8d05583e76c335c465684cec6d55093
Author: Harald Jensås <email address hidden>
Date: Thu Sep 26 13:40:08 2019 +0200

    Add support to set option:mtu in inspector dnsmasq

    It should be possible to configure the DHCP server to
    provide the mtu option for inspection subnets.

    This uses the dhcp-option-force so that the option is
    provided also when the client does not ask for it.
    According to dnsmasq manual page this is sometimes
    required when sending options to PXELINUX.

    Closes-Bug: #1845487
    Change-Id: Ic95dbf1867fb5397f1b6d8f23466910a97051cb6

Changed in puppet-ironic:
status: In Progress → Fix Released
Changed in tripleo:
milestone: train-rc1 → ussuri-1

This issue was fixed in the openstack/puppet-ironic 15.4.0 release.

Reviewed: https://review.opendev.org/685341
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=62286d200a8a15003165aea69515d2441aeddcd8
Submitter: Zuul
Branch: stable/queens

commit 62286d200a8a15003165aea69515d2441aeddcd8
Author: Harald Jensås <email address hidden>
Date: Thu Sep 26 13:40:08 2019 +0200

    Add support to set option:mtu in inspector dnsmasq

    It should be possible to configure the DHCP server to
    provide the mtu option for inspection subnets.

    This uses the dhcp-option-force so that the option is
    provided also when the client does not ask for it.
    According to dnsmasq manual page this is sometimes
    required when sending options to PXELINUX.

    Closes-Bug: #1845487
    Change-Id: Ic95dbf1867fb5397f1b6d8f23466910a97051cb6
    (cherry picked from commit 03550bc8c8d05583e76c335c465684cec6d55093)

tags: added: in-stable-queens
tags: added: in-stable-stein

Reviewed: https://review.opendev.org/685335
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=987a46a15dc1cfa541b73c7093ce362569d049dd
Submitter: Zuul
Branch: stable/stein

commit 987a46a15dc1cfa541b73c7093ce362569d049dd
Author: Harald Jensås <email address hidden>
Date: Thu Sep 26 13:40:08 2019 +0200

    Add support to set option:mtu in inspector dnsmasq

    It should be possible to configure the DHCP server to
    provide the mtu option for inspection subnets.

    This uses the dhcp-option-force so that the option is
    provided also when the client does not ask for it.
    According to dnsmasq manual page this is sometimes
    required when sending options to PXELINUX.

    Closes-Bug: #1845487
    Change-Id: Ic95dbf1867fb5397f1b6d8f23466910a97051cb6
    (cherry picked from commit 03550bc8c8d05583e76c335c465684cec6d55093)

Reviewed: https://review.opendev.org/685338
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=163b8de38f2712eccfdd8edd09aac6eae71f585c
Submitter: Zuul
Branch: stable/rocky

commit 163b8de38f2712eccfdd8edd09aac6eae71f585c
Author: Harald Jensås <email address hidden>
Date: Thu Sep 26 13:40:08 2019 +0200

    Add support to set option:mtu in inspector dnsmasq

    It should be possible to configure the DHCP server to
    provide the mtu option for inspection subnets.

    This uses the dhcp-option-force so that the option is
    provided also when the client does not ask for it.
    According to dnsmasq manual page this is sometimes
    required when sending options to PXELINUX.

    Closes-Bug: #1845487
    Change-Id: Ic95dbf1867fb5397f1b6d8f23466910a97051cb6
    (cherry picked from commit 03550bc8c8d05583e76c335c465684cec6d55093)

tags: added: in-stable-rocky

Reviewed: https://review.opendev.org/685065
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=ff31fe18ec028e6d187de2c3fda539d28caf0a27
Submitter: Zuul
Branch: master

commit ff31fe18ec028e6d187de2c3fda539d28caf0a27
Author: Harald Jensås <email address hidden>
Date: Thu Sep 26 14:50:07 2019 +0200

    Set option:mtu in inspector dnsmasq

    Set the mtu for all subnets in inspector dnsmasq
    config to value of 'local_mtu' in undercloud.conf.

    Closes-Bug: #1845487
    Depends-On: Ic95dbf1867fb5397f1b6d8f23466910a97051cb6
    Change-Id: Iafe3156ca0678f3ab3c5e688e712a9fb6b408e7b

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.opendev.org/687342
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=9df061369fb3ba41432ae79c121d4aa334ca9d7c
Submitter: Zuul
Branch: stable/rocky

commit 9df061369fb3ba41432ae79c121d4aa334ca9d7c
Author: Harald Jensås <email address hidden>
Date: Tue Oct 8 18:02:20 2019 +0200

    Set option:mtu in inspector dnsmasq

    Set the mtu for all subnets in inspector dnsmasq
    config to value of 'local_mtu' in undercloud.conf.

    Change-Id: I2c6759f750de335b81c6335da7be8e09375c981a
    Closes-Bug: #1845487
    Depends-On: Ic95dbf1867fb5397f1b6d8f23466910a97051cb6

Reviewed: https://review.opendev.org/687344
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=70c4c33cf7efa1b800663f41d36b1b6cd24c5d08
Submitter: Zuul
Branch: stable/queens

commit 70c4c33cf7efa1b800663f41d36b1b6cd24c5d08
Author: Harald Jensås <email address hidden>
Date: Tue Oct 8 18:02:20 2019 +0200

    Set option:mtu in inspector dnsmasq

    Set the mtu for all subnets in inspector dnsmasq
    config to value of 'local_mtu' in undercloud.conf.

    Change-Id: I2c6759f750de335b81c6335da7be8e09375c981a
    Closes-Bug: #1845487
    Depends-On: Ic95dbf1867fb5397f1b6d8f23466910a97051cb6
    (cherry picked from commit 0528a93587c5058a5cd9162932202b92dfb43422)

Reviewed: https://review.opendev.org/687308
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=01a7cbbad0a7ddd3ec3be296d7d89987d6dd5fc2
Submitter: Zuul
Branch: stable/stein

commit 01a7cbbad0a7ddd3ec3be296d7d89987d6dd5fc2
Author: Harald Jensås <email address hidden>
Date: Thu Sep 26 14:50:07 2019 +0200

    Set option:mtu in inspector dnsmasq

    Set the mtu for all subnets in inspector dnsmasq
    config to value of 'local_mtu' in undercloud.conf.

    Conflicts:
      tripleoclient/tests/v1/undercloud/test_config.py

    Closes-Bug: #1845487
    Depends-On: Ic95dbf1867fb5397f1b6d8f23466910a97051cb6
    Change-Id: Iafe3156ca0678f3ab3c5e688e712a9fb6b408e7b
    (cherry picked from commit ff31fe18ec028e6d187de2c3fda539d28caf0a27)

Reviewed: https://review.opendev.org/687320
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=2e6358a61a4b83b038759300f5307aabcf51788d
Submitter: Zuul
Branch: stable/rocky

commit 2e6358a61a4b83b038759300f5307aabcf51788d
Author: Harald Jensås <email address hidden>
Date: Thu Sep 26 14:50:07 2019 +0200

    Set option:mtu in inspector dnsmasq

    Set the mtu for all subnets in inspector dnsmasq
    config to value of 'local_mtu' in undercloud.conf.

    Conflicts:
      tripleoclient/tests/v1/undercloud/test_config.py
      tripleoclient/v1/undercloud_config.py

    NOTE, tripleoclient/tests/v1/undercloud/test_config.py
    was named test_undercloud_config.py in rocky and the
    relevant unit tests did not exist.

    Closes-Bug: #1845487
    Depends-On: Ic95dbf1867fb5397f1b6d8f23466910a97051cb6
    Change-Id: Iafe3156ca0678f3ab3c5e688e712a9fb6b408e7b
    (cherry picked from commit ff31fe18ec028e6d187de2c3fda539d28caf0a27)

This issue was fixed in the openstack/python-tripleoclient 12.3.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers