Ironic Inspector must control the dhcp server

[Harald Jensås]

With Ironic Inspector in the undercloud now using the dnsmasq PXE filter there is a scenario where the dhcp server configuration and what Ironic Inspector intend the configuration to be goes out-of-sync.

See https://storyboard.openstack.org/#!/story/2002818 for more details.

The undercloud need to provide commands for ironic inspector to allow it to start/stop the dnsmasq service to ensure the dhcp server configuration is updated when inspector is restarted/stopped/started and the dhcp-hosts filter is purged.

[Bogdan Dobrelya (bogdando)]

That command for undercloud, isn't it required for overcloud ironic as well?

[Harald Jensås (harald-jensas)]

@Bogdan

It is required for overcloud as well.
Since we have contanerized undercloud the fix shuould be the same I think.

But what command can we run in the ironic-inspector container that will restart dnsmasq which afaict runs in a different container?

A fix for instack-undercloud is required as well, to be backported to queens.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/593498

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/593498
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=7bcdb7f7deaf8446927c481e007a79b12d8201be
Submitter: Zuul
Branch: master

commit 7bcdb7f7deaf8446927c481e007a79b12d8201be
Author: Harald Jensås <email address hidden>
Date: Thu Aug 16 16:27:42 2018 +0200

    Add start/stop command for ironic-inspector-dnsmasq

    When the PXE filter's dhcp-hostsdir is purged on start/stop
    of the ironic-inspector service inspectors dnsmasq service
    must also be restarted to ensure that the dhcp server config
    is updated as well.

    Partial-bug: #1780421
    Depends-On: Ie961ec4d3b6b65a462e2d2493f5b9240c2bfa7a6
    Change-Id: I22c7be368b62ef93efabcbd2c13599625ea45548

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/598228

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/598229

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/598228
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=ad692446430723df70372133b215f92fe982d964
Submitter: Zuul
Branch: stable/rocky

commit ad692446430723df70372133b215f92fe982d964
Author: Harald Jensås <email address hidden>
Date: Thu Aug 16 16:27:42 2018 +0200

    Add start/stop command for ironic-inspector-dnsmasq

    When the PXE filter's dhcp-hostsdir is purged on start/stop
    of the ironic-inspector service inspectors dnsmasq service
    must also be restarted to ensure that the dhcp server config
    is updated as well.

    Partial-bug: #1780421
    Depends-On: Ie961ec4d3b6b65a462e2d2493f5b9240c2bfa7a6
    Change-Id: I22c7be368b62ef93efabcbd2c13599625ea45548
    (cherry picked from commit 7bcdb7f7deaf8446927c481e007a79b12d8201be)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/598229
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=40ede6260cd56ed74a6d61cfac0a6a7c03fb5dc8
Submitter: Zuul
Branch: stable/queens

commit 40ede6260cd56ed74a6d61cfac0a6a7c03fb5dc8
Author: Harald Jensås <email address hidden>
Date: Thu Aug 16 16:27:42 2018 +0200

    Add start/stop command for ironic-inspector-dnsmasq

    When the PXE filter's dhcp-hostsdir is purged on start/stop
    of the ironic-inspector service inspectors dnsmasq service
    must also be restarted to ensure that the dhcp server config
    is updated as well.

    Partial-bug: #1780421
    Depends-On: Ie961ec4d3b6b65a462e2d2493f5b9240c2bfa7a6
    Change-Id: I22c7be368b62ef93efabcbd2c13599625ea45548
    (cherry picked from commit 7bcdb7f7deaf8446927c481e007a79b12d8201be)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/613361

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/613361
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=48e7aba0bfb116b9370cc337eb966cd27393a7e5
Submitter: Zuul
Branch: master

commit 48e7aba0bfb116b9370cc337eb966cd27393a7e5
Author: Harald Jensås <email address hidden>
Date: Thu Oct 25 17:21:26 2018 +0200

    Do not purge the Ironic Inspector dhcp-hostsdir

    Since the ironic-inspector service and the dnsmasq
    service for ironic-inspector is running in different
    containters, having the ironic-inspector service
    start/stop the dnsmasq service is non-trivial.

    Using `--pid="host"` and making the containers
    priviligeied seems less than ideal.

    This changes the ironic-inspector configuration so
    that it will no longer purge the dhcp-hosts dir on
    intialization. Purging the directory without also
    restarting (or HUP) the dnsmasq service can cause
    the configuration in the DHCP service to deviate
    from what ironic-inspector intend it to be.

    Related-Bug: #1780421
    Depends-On: Icc532115891c567dde20a28110bf08f54187c49f
    Change-Id: Id26b578b57c46f9993459f83b5f90393d7798a82

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/616882

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616882
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d10e70482ab497728f2178f3c0862db75eac49fd
Submitter: Zuul
Branch: stable/rocky

commit d10e70482ab497728f2178f3c0862db75eac49fd
Author: Harald Jensås <email address hidden>
Date: Thu Oct 25 17:21:26 2018 +0200

    Do not purge the Ironic Inspector dhcp-hostsdir

    Since the ironic-inspector service and the dnsmasq
    service for ironic-inspector is running in different
    containters, having the ironic-inspector service
    start/stop the dnsmasq service is non-trivial.

    Using `--pid="host"` and making the containers
    priviligeied seems less than ideal.

    This changes the ironic-inspector configuration so
    that it will no longer purge the dhcp-hosts dir on
    intialization. Purging the directory without also
    restarting (or HUP) the dnsmasq service can cause
    the configuration in the DHCP service to deviate
    from what ironic-inspector intend it to be.

    Related-Bug: #1780421
    Depends-On: Icc532115891c567dde20a28110bf08f54187c49f
    Change-Id: Id26b578b57c46f9993459f83b5f90393d7798a82
    (cherry picked from commit 48e7aba0bfb116b9370cc337eb966cd27393a7e5)

[Marios Andreou (marios-b)]

This is an automated action. Bug status has been set to 'Incomplete' and target milestone has been removed due to inactivity. If you disagree please re-set these values and reach out to us on freenode #tripleo