Ironic introspection loops over ipxe.efi for UEFI

[Bob Fournier]

When starting introspection for a system using UEFI, the node loops at PXE booting after downloading ipxe.efi.

It has been found that the dhcp-boot setting in dnsmasq.conf is incorrect when using UEFI and iPXE.

The dhcp-boot setting for UEFI should be changed
from:
dhcp-boot=tag:efi,ipxe.efi
to:
dhcp-boot=tag:efi,tag:!ipxe,ipxe.efi

This will prevent dhcp-boot from being set to ipxe.efi when the client is running ipxe, i.e. it should be set using the prior rule, e.g.
dhcp-boot=tag:ipxe,http://<local_ip>/inspector.ipxe

In addition, in order to be support architectures that use architecture type 9 from https://tools.ietf.org/html/rfc4578#page-2

            Type Architecture Name
            ---- -----------------
              0 Intel x86PC
              1 NEC/PC98
              2 EFI Itanium
              3 DEC Alpha
              4 Arc x86
              5 Intel Lean Client
              6 EFI IA32
              7 EFI BC
              8 EFI Xscale
              9 EFI x86-64

there should be a dhcp-match for type 9:
dhcp-match=set:efi,option:client-arch,9
in addition to the current match for type 7:
dhcp-match=set:efi,option:client-arch,7

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/499750

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/499750
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=9d7d8e7042b23832e6dc973cfd06e758ea2129e2
Submitter: Jenkins
Branch: master

commit 9d7d8e7042b23832e6dc973cfd06e758ea2129e2
Author: Bob Fournier <email address hidden>
Date: Thu Aug 31 14:07:55 2017 -0400

    Fixes for Ironic-inspector introspection when client using UEFI

    This fixes an issue during introspection when the client loops
    over ipxe.efi when using UEFI. In addition it adds support to handle
    clients which report UEFI client architecture type 9 (EFI x86-64).

    Change-Id: I236a58aab4000395154e5f463bad07f65b8d8b64
    Closes-Bug: 1714320

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/501445

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501445
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=13e23f70b8395a7e7bc6dc6930c4f71a86e17efe
Submitter: Jenkins
Branch: stable/pike

commit 13e23f70b8395a7e7bc6dc6930c4f71a86e17efe
Author: Bob Fournier <email address hidden>
Date: Thu Aug 31 14:07:55 2017 -0400

    Fixes for Ironic-inspector introspection when client using UEFI

    This fixes an issue during introspection when the client loops
    over ipxe.efi when using UEFI. In addition it adds support to handle
    clients which report UEFI client architecture type 9 (EFI x86-64).

    Change-Id: I236a58aab4000395154e5f463bad07f65b8d8b64
    Closes-Bug: 1714320
    (cherry picked from commit 9d7d8e7042b23832e6dc973cfd06e758ea2129e2)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/501756

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/501756
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=64a3b773f31b11c6d57c83f7acfe26a90bf6cc67
Submitter: Jenkins
Branch: stable/ocata

commit 64a3b773f31b11c6d57c83f7acfe26a90bf6cc67
Author: Bob Fournier <email address hidden>
Date: Thu Aug 31 14:07:55 2017 -0400

    Fixes for Ironic-inspector introspection when client using UEFI

    This fixes an issue during introspection when the client loops
    over ipxe.efi when using UEFI. In addition it adds support to handle
    clients which report UEFI client architecture type 9 (EFI x86-64).

    Change-Id: I236a58aab4000395154e5f463bad07f65b8d8b64
    Closes-Bug: 1714320
    (cherry picked from commit 9d7d8e7042b23832e6dc973cfd06e758ea2129e2)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/502365

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/502365
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=ec33c9af0e2595567de2128ed66494b20af8dc6a
Submitter: Jenkins
Branch: stable/newton

commit ec33c9af0e2595567de2128ed66494b20af8dc6a
Author: Bob Fournier <email address hidden>
Date: Thu Aug 31 14:07:55 2017 -0400

    Fixes for Ironic-inspector introspection when client using UEFI

    This fixes an issue during introspection when the client loops
    over ipxe.efi when using UEFI. In addition it adds support to handle
    clients which report UEFI client architecture type 9 (EFI x86-64).

    Change-Id: I236a58aab4000395154e5f463bad07f65b8d8b64
    Closes-Bug: 1714320
    (cherry picked from commit 9d7d8e7042b23832e6dc973cfd06e758ea2129e2)
    (cherry picked from commit 64a3b773f31b11c6d57c83f7acfe26a90bf6cc67)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ironic 12.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ironic 11.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ironic 9.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ironic 10.5.0 release.