(...) is declared more than once in the parameter list

[Emilien Macchi]

Puppet 3.8.5 released 1 day ago broke syntax jobs for some modules.

It's because of this commit: https://github.com/puppetlabs/puppet/commit/8df197b7046bedad928c648dfcbf434c386a09df

[Emilien Macchi (emilienm)]

Example of failures: http://logs.openstack.org/36/271336/1/check/gate-puppet-ironic-puppet-syntax-3-dsvm-centos7/f321f19/console.html#_2016-01-22_20_48_37_941

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/271581

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/271581
Committed: https://git.openstack.org/cgit/openstack/puppet-murano/commit/?id=93f887e42904fc75087df8370970427f837f7177
Submitter: Jenkins
Branch: master

commit 93f887e42904fc75087df8370970427f837f7177
Author: Alex Schultz <email address hidden>
Date: Fri Jan 22 17:38:10 2016 -0700

    Remove duplicate params and drop mock

    This change removes the duplicate database_max_retries parameter from
    the murano class.

    mock is not used anywhere in the module, let's drop it.
    This patch will help to hit this bug:
    https://launchpad.net/bugs/1492636

    Change-Id: Iddf9f1287e4181e1a5348aa86505ca0abf14cb34
    Closes-Bug: #1537251
    Co-Authored-By: Emilien Macchi <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/271575
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=4dd2bff699dad3a29dddd778cf3e9a940e44a935
Submitter: Jenkins
Branch: master

commit 4dd2bff699dad3a29dddd778cf3e9a940e44a935
Author: Alex Schultz <email address hidden>
Date: Fri Jan 22 17:09:14 2016 -0700

    Fix duplicate parameters and drop mock

    This change removes the duplicate parameters from the main ironic class.
    With the update to 3.8.5, this now shows up as a syntax error in the
    syntax jobs. We should only define these parameters once.

    Also mock is not used anywhere in the module, let's drop it.
    This patch will help to hit this bug:
    https://launchpad.net/bugs/1492636

    Change-Id: Iaa6acafdc771118c74f85f3332f01b58d233743b
    Closes-Bug: #1537251
    Co-Authored-By: Emilien Macchi <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/272175

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/272177

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272177
Committed: https://git.openstack.org/cgit/openstack/puppet-murano/commit/?id=e3c92c69fedb12d3e0f986f8bd475fcfde4b5cd8
Submitter: Jenkins
Branch: stable/liberty

commit e3c92c69fedb12d3e0f986f8bd475fcfde4b5cd8
Author: Alex Schultz <email address hidden>
Date: Fri Jan 22 17:38:10 2016 -0700

    Remove duplicate params and drop mock

    This change removes the duplicate database_max_retries parameter from
    the murano class.

    mock is not used anywhere in the module, let's drop it.
    This patch will help to hit this bug:
    https://launchpad.net/bugs/1492636

    Change-Id: Iddf9f1287e4181e1a5348aa86505ca0abf14cb34
    Closes-Bug: #1537251
    Co-Authored-By: Emilien Macchi <email address hidden>
    (cherry picked from commit 93f887e42904fc75087df8370970427f837f7177)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/272175
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=958ea03e70162f90ffa2b11cabf42990bd39e8d1
Submitter: Jenkins
Branch: stable/liberty

commit 958ea03e70162f90ffa2b11cabf42990bd39e8d1
Author: Alex Schultz <email address hidden>
Date: Fri Jan 22 17:09:14 2016 -0700

    Fix duplicate parameters and drop mock

    This change removes the duplicate parameters from the main ironic class.
    With the update to 3.8.5, this now shows up as a syntax error in the
    syntax jobs. We should only define these parameters once.

    Also mock is not used anywhere in the module, let's drop it.
    This patch will help to hit this bug:
    https://launchpad.net/bugs/1492636

    Change-Id: Iaa6acafdc771118c74f85f3332f01b58d233743b
    Closes-Bug: #1537251
    Co-Authored-By: Emilien Macchi <email address hidden>
    (cherry picked from commit 4dd2bff699dad3a29dddd778cf3e9a940e44a935)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-ironic 7.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-murano 7.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-sahara 7.1.0 release.