no log_dir configed after ironic installation

Bug #1468620 reported by gs-opencos-zte on 2015-06-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-ironic
High
gs-opencos-zte

Bug Description

when i intalled openstack Kilo with ironic component , i found no log file in /var/log/ for ironic, but all the other components have logs in the directory, then i add log_dir in /usr/share/openstack-puppet/modules/ironic/manifests/init.pp, and the ironic logs created after installing again.

code:
# [*log_dir*]
# (optional) Directory where logs should be stored.
# If set to boolean false, it will not log to any directory.
# Defaults to '/var/log/ironic'
.....

class ironic (
  .....
  $log_dir = '/var/log/ironic',
)
.....

  if $log_dir {
    file { $log_dir:
      ensure => directory,
      mode => '0750',
      owner => 'ironic',
      group => $::ironic::params::nova_log_group,
      require => Package['ironic-common'],
    }
    ironic_config { 'DEFAULT/log_dir': value => $log_dir;}
  } else {
    ironic_config { 'DEFAULT/log_dir': ensure => absent;}
  }

ironic_config {
.....
}

Emilien Macchi (emilienm) wrote :

the code you're mentioning is what we do in other modules, except we try to not manage user/groups/mode.
If you're willing to submit a patch, feel free to assign the bug to yourself.

Thanks

Changed in puppet-ironic:
status: New → Confirmed
importance: Undecided → High
Changed in puppet-ironic:
assignee: nobody → gs-opencos-zte (gs-opencos-zte)
Changed in puppet-ironic:
status: Confirmed → In Progress

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/198225
Reason: This review is > 4 weeks without comment or failed Jenkins or merge conflict the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers