SECRET_KEY is leaked in puppt output

[Takashi Kajinami]

The local_settings file stores the SECRET_KEY parameter in a plane text format.
Because we don't disable diff, the key content is displayed in the puppet log, during initial deployment or the key is changed.

https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_35b/853178/5/check/puppet-openstack-integration-7-scenario003-tempest-centos-9-stream/35b383f/logs/puppet-20220819_004654.txt

```
2022-08-19 00:27:11 +0000 /Stage[main]/Horizon/Concat[/etc/openstack-dashboard/local_settings]/File[/etc/openstack-dashboard/local_settings]/content (notice):
--- /etc/openstack-dashboard/local_settings 2022-08-19 00:22:31.424520479 +0000
+++ /tmp/puppet-file20220819-98173-1ohu0iz 2022-08-19 00:27:11.319834990 +0000
@@ -1,54 +1,94 @@
-# -*- coding: utf-8 -*-
...

 # Set custom secret key:
 # You can either set it to a specific value or you can let horizon generate a
@@ -84,25 +134,31 @@
 # (usually behind a load-balancer). Either you have to make sure that a session
 # gets all requests routed to the same dashboard instance or you set the same
 # SECRET_KEY for all of them.
-SECRET_KEY='b7597ab43479af1ad712'
+#SECRET_KEY = secret_key.generate_or_read_from_file(
+# os.path.join(LOCAL_PATH, '.secret_key_store'))
+SECRET_KEY = 'big_secret'

...
```

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/853744

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/853744
Committed: https://opendev.org/openstack/puppet-horizon/commit/a810ca2b4ef29eb166eb8f1041643a31262be49c
Submitter: "Zuul (22348)"
Branch: master

commit a810ca2b4ef29eb166eb8f1041643a31262be49c
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 19 11:27:04 2022 +0900

    Do not show diff of local_settings(.py)

    ... because the file contains a few sensitive values like SECRET_KEY.

    Closes-Bug: #1987015
    Change-Id: Ie96eb626148214270c5a3a041087fcc679c127ce

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/853760

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/853760
Committed: https://opendev.org/openstack/puppet-horizon/commit/cf626d236763d9c739a41c06b6b891a0b6f6603f
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit cf626d236763d9c739a41c06b6b891a0b6f6603f
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 19 11:27:04 2022 +0900

    Do not show diff of local_settings(.py)

    ... because the file contains a few sensitive values like SECRET_KEY.

    Closes-Bug: #1987015
    Change-Id: Ie96eb626148214270c5a3a041087fcc679c127ce
    (cherry picked from commit a810ca2b4ef29eb166eb8f1041643a31262be49c)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/854018

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/854018
Committed: https://opendev.org/openstack/puppet-horizon/commit/06cb3015a33d14d23403371838d4270b6c3d1dbd
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 06cb3015a33d14d23403371838d4270b6c3d1dbd
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 19 11:27:04 2022 +0900

    Do not show diff of local_settings(.py)

    ... because the file contains a few sensitive values like SECRET_KEY.

    Closes-Bug: #1987015
    Change-Id: Ie96eb626148214270c5a3a041087fcc679c127ce
    (cherry picked from commit a810ca2b4ef29eb166eb8f1041643a31262be49c)
    (cherry picked from commit cf626d236763d9c739a41c06b6b891a0b6f6603f)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/854137

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/854137
Committed: https://opendev.org/openstack/puppet-horizon/commit/69539a2543c8e315231f1d0e0da894058329c065
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 69539a2543c8e315231f1d0e0da894058329c065
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 19 11:27:04 2022 +0900

    Do not show diff of local_settings(.py)

    ... because the file contains a few sensitive values like SECRET_KEY.

    Closes-Bug: #1987015
    Change-Id: Ie96eb626148214270c5a3a041087fcc679c127ce
    (cherry picked from commit a810ca2b4ef29eb166eb8f1041643a31262be49c)
    (cherry picked from commit cf626d236763d9c739a41c06b6b891a0b6f6603f)
    (cherry picked from commit 06cb3015a33d14d23403371838d4270b6c3d1dbd)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/854892

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/854892
Committed: https://opendev.org/openstack/puppet-horizon/commit/e10f6469ab7355970046c96738e630a07bbdf12b
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit e10f6469ab7355970046c96738e630a07bbdf12b
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 19 11:27:04 2022 +0900

    Do not show diff of local_settings(.py)

    ... because the file contains a few sensitive values like SECRET_KEY.

    Closes-Bug: #1987015
    Change-Id: Ie96eb626148214270c5a3a041087fcc679c127ce
    (cherry picked from commit a810ca2b4ef29eb166eb8f1041643a31262be49c)
    (cherry picked from commit cf626d236763d9c739a41c06b6b891a0b6f6603f)
    (cherry picked from commit 06cb3015a33d14d23403371838d4270b6c3d1dbd)
    (cherry picked from commit 69539a2543c8e315231f1d0e0da894058329c065)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/855139

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/855139
Committed: https://opendev.org/openstack/puppet-horizon/commit/4d20a7aeb11e48e3df3443596a3c9efac87c137e
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 4d20a7aeb11e48e3df3443596a3c9efac87c137e
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 19 11:27:04 2022 +0900

    Do not show diff of local_settings(.py)

    ... because the file contains a few sensitive values like SECRET_KEY.

    Closes-Bug: #1987015
    Change-Id: Ie96eb626148214270c5a3a041087fcc679c127ce
    (cherry picked from commit a810ca2b4ef29eb166eb8f1041643a31262be49c)
    (cherry picked from commit cf626d236763d9c739a41c06b6b891a0b6f6603f)
    (cherry picked from commit 06cb3015a33d14d23403371838d4270b6c3d1dbd)
    (cherry picked from commit 69539a2543c8e315231f1d0e0da894058329c065)
    (cherry picked from commit e10f6469ab7355970046c96738e630a07bbdf12b)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/855536

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/855536
Committed: https://opendev.org/openstack/puppet-horizon/commit/b1f3b4f89e4f2c3bb226e0be892817934dcb284e
Submitter: "Zuul (22348)"
Branch: stable/train

commit b1f3b4f89e4f2c3bb226e0be892817934dcb284e
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 19 11:27:04 2022 +0900

    Do not show diff of local_settings(.py)

    ... because the file contains a few sensitive values like SECRET_KEY.

    Conflicts:
            spec/classes/horizon_init_spec.rb

    Resolved conflict caused by RHEL/CentOS 7 support which was removed
    during Ussuri cycle.

    Closes-Bug: #1987015
    Change-Id: Ie96eb626148214270c5a3a041087fcc679c127ce
    (cherry picked from commit a810ca2b4ef29eb166eb8f1041643a31262be49c)
    (cherry picked from commit cf626d236763d9c739a41c06b6b891a0b6f6603f)
    (cherry picked from commit 06cb3015a33d14d23403371838d4270b6c3d1dbd)
    (cherry picked from commit 69539a2543c8e315231f1d0e0da894058329c065)
    (cherry picked from commit e10f6469ab7355970046c96738e630a07bbdf12b)
    (cherry picked from commit 4d20a7aeb11e48e3df3443596a3c9efac87c137e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon 21.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon 18.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon 19.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon 20.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon victoria-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon train-eol release.