dashboards and default_dashboad have been deprecated

[Takashi Kajinami]

We are currently observing the following warming message in horizon log.

https://a316c4765341093edd90-e208a545991c854bd1a90a063fbc0070.ssl.cf1.rackcdn.com/834838/9/gate/puppet-openstack-integration-7-scenario003-tempest-centos-9-stream/d186dec/logs/apache/horizon_ssl_error.txt

[Tue Aug 02 13:41:40.955426 2022] [wsgi:error] [pid 130159:tid 130236] WARNING:root:"dashboards" and "default_dashboard" in (local_)settings is DEPRECATED now and may be unsupported in some future release. The preferred way to specify the order of dashboards and the default dashboard is the pluggable dashboard mechanism (in /usr/share/openstack-dashboard/openstack_dashboard/enabled, /usr/share/openstack-dashboard/openstack_dashboard/local/enabled).

Actually these options were deprecated long ago by [1].

[1] https://review.opendev.org/c/openstack/horizon/+/119545

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/852038

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/852038
Committed: https://opendev.org/openstack/puppet-horizon/commit/57905ff386f93dd4f6b80deb312c3bfbc605e707
Submitter: "Zuul (22348)"
Branch: master

commit 57905ff386f93dd4f6b80deb312c3bfbc605e707
Author: Takashi Kajinami <email address hidden>
Date: Thu Aug 4 00:52:03 2022 +0900

    Drop default_dashboard

    default_dashboard was deprecated a long ago in Horizon[1] and
    Having that parameter in local_settings triggers the following warning
    message.

    ```
    WARNING:root:"dashboards" and "default_dashboard" in (local_)settings
    is DEPRECATED now and may be unsupported in some future release.
    The preferred way to specify the order of dashboards and the default
    dashboard is the pluggable dashboard mechanism (in ...).
    ```

    This change removes that parameter hard-coded in the template file to
    get rid of the warning message. Currently the project dashboard is
    shown first in Horizon by default so removing the parameter does not
    cause any change in behavior.

    This also removes these deprecated parameters from the template file
    used in unit tests.

    [1] 75bc2e6aa86d31f60288021694699302b3873af3

    Closes-Bug: #1983390
    Change-Id: I8cd5346a553db9ba9f6bdf8ffdd9e7d89d16c4be

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon 21.0.0 release.