puppet-horizon

Heat dashboard crashes because of syntax error in _1699_orchestration_settings.py

Bug #1965970 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
Critical
Takashi Kajinami

Bug Description

Currently horizon can't start up properly when heat dashboard is enabled.

~~~
Can not exec settings snippet _1699_orchestration_settings.py
Traceback (most recent call last):
  File "/usr/share/openstack-dashboard/openstack_dashboard/settings.py", line 272, in <module>
    exec(f.read())
  File "<string>", line 29
    'level': 'INFO',
          ^
SyntaxError: invalid syntax
~~~

The error is caused by missing comma in the handlers line.

https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_dfd/834614/2/check/puppet-openstack-integration-7-scenario003-tempest-centos-8-stream/dfd7e78/logs/etc/openstack-dashboard/local_settings.d/_1699_orchestration_settings.py.txt
~~~
settings.LOGGING['loggers'].update({
    'heatclient': {
        # 'handlers': ['console'],
        'handlers': ['file']
        # level': 'DEBUG',
        'level': 'DEBUG',
        'propagate': False,
    }
})
~~~

Takashi Kajinami (kajinamit)
Changed in puppet-horizon:
importance: Undecided → Critical
assignee: nobody → Takashi Kajinami (kajinamit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/834745

Changed in puppet-horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/834714

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/834715

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/834716

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/834748

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/834749

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/834714
Committed: https://opendev.org/openstack/puppet-horizon/commit/f80cb0ff33d9cb1e953b4af2a21da6cefb0dc770
Submitter: "Zuul (22348)"
Branch: stable/xena

commit f80cb0ff33d9cb1e953b4af2a21da6cefb0dc770
Author: Takashi Kajinami <email address hidden>
Date: Wed Mar 23 01:45:17 2022 +0900

    Fix syntax error in individual dashboard settings

    Closes-Bug: #1965970
    Change-Id: Ie866b35306cadb5e7dad53b0c05c84023c134c3b
    (cherry picked from commit 2c33f9fb5e4f034c9cc1763bfb6ff82034df8ccf)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/834715
Committed: https://opendev.org/openstack/puppet-horizon/commit/9a6961d551bcb670c3925955adc485bc42d97f5a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9a6961d551bcb670c3925955adc485bc42d97f5a
Author: Takashi Kajinami <email address hidden>
Date: Wed Mar 23 01:45:17 2022 +0900

    Fix syntax error in individual dashboard settings

    Closes-Bug: #1965970
    Change-Id: Ie866b35306cadb5e7dad53b0c05c84023c134c3b
    (cherry picked from commit 2c33f9fb5e4f034c9cc1763bfb6ff82034df8ccf)
    (cherry picked from commit f80cb0ff33d9cb1e953b4af2a21da6cefb0dc770)

tags: added: in-stable-wallaby
tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/834716
Committed: https://opendev.org/openstack/puppet-horizon/commit/11ffe2370d158e039cd8f5df1e9fcdcf7243d646
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 11ffe2370d158e039cd8f5df1e9fcdcf7243d646
Author: Takashi Kajinami <email address hidden>
Date: Wed Mar 23 01:45:17 2022 +0900

    Fix syntax error in individual dashboard settings

    Closes-Bug: #1965970
    Change-Id: Ie866b35306cadb5e7dad53b0c05c84023c134c3b
    (cherry picked from commit 2c33f9fb5e4f034c9cc1763bfb6ff82034df8ccf)
    (cherry picked from commit f80cb0ff33d9cb1e953b4af2a21da6cefb0dc770)
    (cherry picked from commit 9a6961d551bcb670c3925955adc485bc42d97f5a)

Changed in puppet-horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/834745
Committed: https://opendev.org/openstack/puppet-horizon/commit/2c33f9fb5e4f034c9cc1763bfb6ff82034df8ccf
Submitter: "Zuul (22348)"
Branch: master

commit 2c33f9fb5e4f034c9cc1763bfb6ff82034df8ccf
Author: Takashi Kajinami <email address hidden>
Date: Wed Mar 23 01:45:17 2022 +0900

    Fix syntax error in individual dashboard settings

    Closes-Bug: #1965970
    Change-Id: Ie866b35306cadb5e7dad53b0c05c84023c134c3b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/834748
Committed: https://opendev.org/openstack/puppet-horizon/commit/616071b15906eeb1385cd5f40a48152b109254aa
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 616071b15906eeb1385cd5f40a48152b109254aa
Author: Takashi Kajinami <email address hidden>
Date: Wed Mar 23 01:45:17 2022 +0900

    Fix syntax error in individual dashboard settings

    Conflicts:
            templates/_1499_load_balancer_settings.py.erb
            templates/_1699_orchestration_settings.py.erb
            templates/_90_manila_shares.py.erb

    Closes-Bug: #1965970
    Change-Id: Ie866b35306cadb5e7dad53b0c05c84023c134c3b
    (cherry picked from commit 2c33f9fb5e4f034c9cc1763bfb6ff82034df8ccf)
    (cherry picked from commit f80cb0ff33d9cb1e953b4af2a21da6cefb0dc770)
    (cherry picked from commit 9a6961d551bcb670c3925955adc485bc42d97f5a)
    (cherry picked from commit 11ffe2370d158e039cd8f5df1e9fcdcf7243d646)

tags: added: in-stable-ussuri
tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/train)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/834749
Committed: https://opendev.org/openstack/puppet-horizon/commit/3c12384f9bb191fb388babb333115686755fce74
Submitter: "Zuul (22348)"
Branch: stable/train

commit 3c12384f9bb191fb388babb333115686755fce74
Author: Takashi Kajinami <email address hidden>
Date: Wed Mar 23 01:45:17 2022 +0900

    Fix syntax error in individual dashboard settings

    Conflicts:
            templates/_1499_load_balancer_settings.py.erb
            templates/_1699_orchestration_settings.py.erb
            templates/_90_manila_shares.py.erb

    Closes-Bug: #1965970
    Change-Id: Ie866b35306cadb5e7dad53b0c05c84023c134c3b
    (cherry picked from commit 2c33f9fb5e4f034c9cc1763bfb6ff82034df8ccf)
    (cherry picked from commit f80cb0ff33d9cb1e953b4af2a21da6cefb0dc770)
    (cherry picked from commit 9a6961d551bcb670c3925955adc485bc42d97f5a)
    (cherry picked from commit 11ffe2370d158e039cd8f5df1e9fcdcf7243d646)
    (cherry picked from commit 616071b15906eeb1385cd5f40a48152b109254aa)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 20.3.0

This issue was fixed in the openstack/puppet-horizon 20.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 17.5.0

This issue was fixed in the openstack/puppet-horizon 17.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 18.6.0

This issue was fixed in the openstack/puppet-horizon 18.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 19.5.0

This issue was fixed in the openstack/puppet-horizon 19.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon ussuri-eol

This issue was fixed in the openstack/puppet-horizon ussuri-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon train-eol

This issue was fixed in the openstack/puppet-horizon train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.