puppet-horizon

Setting of REST_API_REQUIRED_SETTINGS is outdated

Bug #1956904 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
Critical
Takashi Kajinami

Bug Description

Currently value of the REST_API_REQUIRED_SETTINGS parameter is hard-coded but the value is outdated and doesn't include some items.

Basically this parameter should be configured according to what is required by Horizon's implementation and we don't expect that users are likely to customize this. In addition, as is described in the parameter description, removing any item can break functionality.

Takashi Kajinami (kajinamit)
Changed in puppet-horizon:
importance: Undecided → Critical
assignee: nobody → Takashi Kajinami (kajinamit)
OpenStack Infra (hudson-openstack)
Changed in puppet-horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/823933
Committed: https://opendev.org/openstack/puppet-horizon/commit/d48de6a4823ef843401b96eeb8d619cc2797ecd8
Submitter: "Zuul (22348)"
Branch: master

commit d48de6a4823ef843401b96eeb8d619cc2797ecd8
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 10 14:22:40 2022 +0900

    Do not hard-code REST_API_REQUIRED_SETTINGS

    The REST_API_REQUIRED_SETTINGS parameter defines a list of settings
    available to the client side. Basically this parameter should be
    defined according to the requirement by Horizon's implementation.

    This change removes the current hard-code, because the default value
    is now defined in Horizon itself. What is worse, the current value is
    outdated and doesn't include some items, which would break Horizon's
    functionality.

    Closes-Bug: #1956904
    Change-Id: Ie3c13d96e8219b4d80b0641f4def49b858f0513a

Changed in puppet-horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/824821

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/824822

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/824823

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/824824

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/824825

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/824821
Committed: https://opendev.org/openstack/puppet-horizon/commit/a4b70ae5607098848a3d46498f684b3519a76d10
Submitter: "Zuul (22348)"
Branch: stable/xena

commit a4b70ae5607098848a3d46498f684b3519a76d10
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 10 14:22:40 2022 +0900

    Do not hard-code REST_API_REQUIRED_SETTINGS

    The REST_API_REQUIRED_SETTINGS parameter defines a list of settings
    available to the client side. Basically this parameter should be
    defined according to the requirement by Horizon's implementation.

    This change removes the current hard-code, because the default value
    is now defined in Horizon itself. What is worse, the current value is
    outdated and doesn't include some items, which would break Horizon's
    functionality.

    Closes-Bug: #1956904
    Change-Id: Ie3c13d96e8219b4d80b0641f4def49b858f0513a
    (cherry picked from commit d48de6a4823ef843401b96eeb8d619cc2797ecd8)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/824822
Committed: https://opendev.org/openstack/puppet-horizon/commit/83af56402fd597debe6a6bc6fabb40322fb30d55
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 83af56402fd597debe6a6bc6fabb40322fb30d55
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 10 14:22:40 2022 +0900

    Do not hard-code REST_API_REQUIRED_SETTINGS

    The REST_API_REQUIRED_SETTINGS parameter defines a list of settings
    available to the client side. Basically this parameter should be
    defined according to the requirement by Horizon's implementation.

    This change removes the current hard-code, because the default value
    is now defined in Horizon itself. What is worse, the current value is
    outdated and doesn't include some items, which would break Horizon's
    functionality.

    Closes-Bug: #1956904
    Change-Id: Ie3c13d96e8219b4d80b0641f4def49b858f0513a
    (cherry picked from commit d48de6a4823ef843401b96eeb8d619cc2797ecd8)
    (cherry picked from commit a4b70ae5607098848a3d46498f684b3519a76d10)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/824823
Committed: https://opendev.org/openstack/puppet-horizon/commit/1ec51beec42fa2ac994336bb7677ab60659cf160
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 1ec51beec42fa2ac994336bb7677ab60659cf160
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 10 14:22:40 2022 +0900

    Do not hard-code REST_API_REQUIRED_SETTINGS

    The REST_API_REQUIRED_SETTINGS parameter defines a list of settings
    available to the client side. Basically this parameter should be
    defined according to the requirement by Horizon's implementation.

    This change removes the current hard-code, because the default value
    is now defined in Horizon itself. What is worse, the current value is
    outdated and doesn't include some items, which would break Horizon's
    functionality.

    Closes-Bug: #1956904
    Change-Id: Ie3c13d96e8219b4d80b0641f4def49b858f0513a
    (cherry picked from commit d48de6a4823ef843401b96eeb8d619cc2797ecd8)
    (cherry picked from commit a4b70ae5607098848a3d46498f684b3519a76d10)
    (cherry picked from commit 83af56402fd597debe6a6bc6fabb40322fb30d55)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/824824
Committed: https://opendev.org/openstack/puppet-horizon/commit/7c44e3aa21fab702b3df7a973e38f9750d908dc3
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 7c44e3aa21fab702b3df7a973e38f9750d908dc3
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 10 14:22:40 2022 +0900

    Do not hard-code REST_API_REQUIRED_SETTINGS

    The REST_API_REQUIRED_SETTINGS parameter defines a list of settings
    available to the client side. Basically this parameter should be
    defined according to the requirement by Horizon's implementation.

    This change removes the current hard-code, because the default value
    is now defined in Horizon itself. What is worse, the current value is
    outdated and doesn't include some items, which would break Horizon's
    functionality.

    Closes-Bug: #1956904
    Change-Id: Ie3c13d96e8219b4d80b0641f4def49b858f0513a
    (cherry picked from commit d48de6a4823ef843401b96eeb8d619cc2797ecd8)
    (cherry picked from commit a4b70ae5607098848a3d46498f684b3519a76d10)
    (cherry picked from commit 83af56402fd597debe6a6bc6fabb40322fb30d55)
    (cherry picked from commit 1ec51beec42fa2ac994336bb7677ab60659cf160)

tags: added: in-stable-ussuri
tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/train)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/824825
Committed: https://opendev.org/openstack/puppet-horizon/commit/ef5d617b190d3168c7ef1652a6038c5607ed1e32
Submitter: "Zuul (22348)"
Branch: stable/train

commit ef5d617b190d3168c7ef1652a6038c5607ed1e32
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 10 14:22:40 2022 +0900

    Do not hard-code REST_API_REQUIRED_SETTINGS

    The REST_API_REQUIRED_SETTINGS parameter defines a list of settings
    available to the client side. Basically this parameter should be
    defined according to the requirement by Horizon's implementation.

    This change removes the current hard-code, because the default value
    is now defined in Horizon itself. What is worse, the current value is
    outdated and doesn't include some items, which would break Horizon's
    functionality.

    Closes-Bug: #1956904
    Change-Id: Ie3c13d96e8219b4d80b0641f4def49b858f0513a
    (cherry picked from commit d48de6a4823ef843401b96eeb8d619cc2797ecd8)
    (cherry picked from commit a4b70ae5607098848a3d46498f684b3519a76d10)
    (cherry picked from commit 83af56402fd597debe6a6bc6fabb40322fb30d55)
    (cherry picked from commit 1ec51beec42fa2ac994336bb7677ab60659cf160)
    (cherry picked from commit 7c44e3aa21fab702b3df7a973e38f9750d908dc3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 18.5.0

This issue was fixed in the openstack/puppet-horizon 18.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 20.2.0

This issue was fixed in the openstack/puppet-horizon 20.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 17.5.0

This issue was fixed in the openstack/puppet-horizon 17.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 19.5.0

This issue was fixed in the openstack/puppet-horizon 19.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon ussuri-eol

This issue was fixed in the openstack/puppet-horizon ussuri-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon train-eol

This issue was fixed in the openstack/puppet-horizon train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.