HORIZON_IMAGES_UPLOAD_MODE is not quoted automatically

[Takashi Kajinami]

The horizon_upload_mode parameter is used to define the value for the HORIZON_IMAGES_UPLOAD_MODE parameter in local_settings.
However this parameter is not encapsulated with quotes when being rendered into local_settings, and makes horizon fail if users don't include single/double quotes in a string value passed to the parameter.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/812645
Committed: https://opendev.org/openstack/puppet-horizon/commit/625275af36f6775e939334724f439c480d863d24
Submitter: "Zuul (22348)"
Branch: master

commit 625275af36f6775e939334724f439c480d863d24
Author: Matthew J. Black <email address hidden>
Date: Wed Oct 6 04:06:57 2021 -0500

    Fix missing HORIZON_IMAGES_UPLOAD_MODE

    The value as of current is treated as an expression
    by horizon and will cause horizon to fail. The value
    must be encapsulated with quotes so it is treated as
    a string.

    Closes-Bug: #1946277
    Change-Id: I7a900d75ddffae88760d5965a1f9ac2f4277624f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/813651

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/813651
Committed: https://opendev.org/openstack/puppet-horizon/commit/d22f10750cb712c89a7f9164e8b9dabadd3d6d9f
Submitter: "Zuul (22348)"
Branch: stable/xena

commit d22f10750cb712c89a7f9164e8b9dabadd3d6d9f
Author: Matthew J. Black <email address hidden>
Date: Wed Oct 6 04:06:57 2021 -0500

    Fix missing HORIZON_IMAGES_UPLOAD_MODE

    The value as of current is treated as an expression
    by horizon and will cause horizon to fail. The value
    must be encapsulated with quotes so it is treated as
    a string.

    Backport note:
    The deprecation warning message is not included in backports.

    Closes-Bug: #1946277
    Change-Id: I7a900d75ddffae88760d5965a1f9ac2f4277624f
    (cherry picked from commit 625275af36f6775e939334724f439c480d863d24)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/815291

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon 20.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/815291
Committed: https://opendev.org/openstack/puppet-horizon/commit/a12c7720700b79cb3e5da60b91e2b1cd3d76b221
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit a12c7720700b79cb3e5da60b91e2b1cd3d76b221
Author: Matthew J. Black <email address hidden>
Date: Wed Oct 6 04:06:57 2021 -0500

    Fix missing HORIZON_IMAGES_UPLOAD_MODE

    The value as of current is treated as an expression
    by horizon and will cause horizon to fail. The value
    must be encapsulated with quotes so it is treated as
    a string.

    Backport note:
    The deprecation warning message is not included in backports.

    Conflicts:
            manifests/init.pp

    Closes-Bug: #1946277
    Change-Id: I7a900d75ddffae88760d5965a1f9ac2f4277624f
    (cherry picked from commit 625275af36f6775e939334724f439c480d863d24)
    (cherry picked from commit d22f10750cb712c89a7f9164e8b9dabadd3d6d9f)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/853376
Committed: https://opendev.org/openstack/puppet-horizon/commit/6bf7abada90dcbadb04d0cee848aa1430704fecc
Submitter: "Zuul (22348)"
Branch: master

commit 6bf7abada90dcbadb04d0cee848aa1430704fecc
Author: Takashi Kajinami <email address hidden>
Date: Wed Aug 17 09:00:54 2022 +0900

    Remove logic to handle quoted horizon_upload_mode

    This is follow-up of 625275af36f6775e939334724f439c480d863d24 and
    removes the temporal logic to keep compatibility, because we have kept
    the warning message for several cycles.

    Related-Bug: #1946277
    Change-Id: I1b11305df67dbe3127642a96bda429faae0059d5

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon 18.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon 19.5.0 release.