puppet-horizon

The disallow_iframe_embed option doesn't belong to HORIZON_CONFIG

Bug #1942722 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
High
Takashi Kajinami

Bug Description

Currently the disallow_iframe_embed option is described as the following example in local_settings.

~~~
HORIZON_CONFIG["disallow_iframe_embed"] = True
~~~

However this usage is wrong and the option is not part of HORIZON_CONFIG.

The option should be defined as an usual horizon parameter like;
~~~
DISALLOW_IFRAME_EMBED = True
~~~

OpenStack Infra (hudson-openstack)
Changed in puppet-horizon:
status: New → In Progress
Revision history for this message
Takashi Kajinami (kajinamit) wrote :

I've proposed a fix to master: https://review.opendev.org/c/openstack/puppet-horizon/+/807487

Changed in puppet-horizon:
importance: Undecided → High
assignee: nobody → Takashi Kajinami (kajinamit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/807487
Committed: https://opendev.org/openstack/puppet-horizon/commit/7153d5cdfac9288bca22caedb064ea5aa903c2eb
Submitter: "Zuul (22348)"
Branch: master

commit 7153d5cdfac9288bca22caedb064ea5aa903c2eb
Author: Takashi Kajinami <email address hidden>
Date: Mon Sep 6 11:55:41 2021 +0900

    Fix how disallow_iframe_embed is defined

    The disallow_iframe_embed option doesn't belong to HORIZON_CONFIG but
    should be described as a variable in local_settings.

    Closes-Bug: #1942722
    Change-Id: I189fbb0a76ba63e16f6c3b6ad9db6f9e0355617f

Changed in puppet-horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/809659

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/809659
Committed: https://opendev.org/openstack/puppet-horizon/commit/7135e8d99d6e11522006291c224e88a87a4e942b
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 7135e8d99d6e11522006291c224e88a87a4e942b
Author: Takashi Kajinami <email address hidden>
Date: Mon Sep 6 11:55:41 2021 +0900

    Fix how disallow_iframe_embed is defined

    The disallow_iframe_embed option doesn't belong to HORIZON_CONFIG but
    should be described as a variable in local_settings.

    Closes-Bug: #1942722
    Change-Id: I189fbb0a76ba63e16f6c3b6ad9db6f9e0355617f
    (cherry picked from commit 7153d5cdfac9288bca22caedb064ea5aa903c2eb)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 19.4.0

This issue was fixed in the openstack/puppet-horizon 19.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/813630

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/813630
Committed: https://opendev.org/openstack/puppet-horizon/commit/03d3469f718c00bf4bc50eb126298597e8a6f2b5
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 03d3469f718c00bf4bc50eb126298597e8a6f2b5
Author: Takashi Kajinami <email address hidden>
Date: Mon Sep 6 11:55:41 2021 +0900

    Fix how disallow_iframe_embed is defined

    The disallow_iframe_embed option doesn't belong to HORIZON_CONFIG but
    should be described as a variable in local_settings.

    Closes-Bug: #1942722
    Change-Id: I189fbb0a76ba63e16f6c3b6ad9db6f9e0355617f
    (cherry picked from commit 7153d5cdfac9288bca22caedb064ea5aa903c2eb)
    (cherry picked from commit 7135e8d99d6e11522006291c224e88a87a4e942b)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/814947

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/816236

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/train)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/816236
Committed: https://opendev.org/openstack/puppet-horizon/commit/1c58af61c771c23bedbe8204f33eae752f64cfbf
Submitter: "Zuul (22348)"
Branch: stable/train

commit 1c58af61c771c23bedbe8204f33eae752f64cfbf
Author: Takashi Kajinami <email address hidden>
Date: Mon Sep 6 11:55:41 2021 +0900

    Fix how disallow_iframe_embed is defined

    The disallow_iframe_embed option doesn't belong to HORIZON_CONFIG but
    should be described as a variable in local_settings.

    Closes-Bug: #1942722
    Change-Id: I189fbb0a76ba63e16f6c3b6ad9db6f9e0355617f
    (cherry picked from commit 7153d5cdfac9288bca22caedb064ea5aa903c2eb)
    (cherry picked from commit 7135e8d99d6e11522006291c224e88a87a4e942b)
    (cherry picked from commit 03d3469f718c00bf4bc50eb126298597e8a6f2b5)
    (cherry picked from commit c65b7a89c6a2080f75524b79422d5d5c957b28a6)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/814947
Committed: https://opendev.org/openstack/puppet-horizon/commit/c65b7a89c6a2080f75524b79422d5d5c957b28a6
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit c65b7a89c6a2080f75524b79422d5d5c957b28a6
Author: Takashi Kajinami <email address hidden>
Date: Mon Sep 6 11:55:41 2021 +0900

    Fix how disallow_iframe_embed is defined

    The disallow_iframe_embed option doesn't belong to HORIZON_CONFIG but
    should be described as a variable in local_settings.

    Closes-Bug: #1942722
    Change-Id: I189fbb0a76ba63e16f6c3b6ad9db6f9e0355617f
    (cherry picked from commit 7153d5cdfac9288bca22caedb064ea5aa903c2eb)
    (cherry picked from commit 7135e8d99d6e11522006291c224e88a87a4e942b)
    (cherry picked from commit 03d3469f718c00bf4bc50eb126298597e8a6f2b5)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 16.4.0

This issue was fixed in the openstack/puppet-horizon 16.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 18.5.0

This issue was fixed in the openstack/puppet-horizon 18.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 17.5.0

This issue was fixed in the openstack/puppet-horizon 17.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon train-eol

This issue was fixed in the openstack/puppet-horizon train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.