manage "DROPDOWN_MAX_ITEMS" horizon parameter with heat template

Bug #1813786 reported by Pratik Pravin Bandarkar on 2019-01-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Undecided
Tobias Urdin

Bug Description

Currently, "DROPDOWN_MAX_ITEMS" horizon variable is hardcoded in a ruby template. It's not possible to manage it using heat.
<snip>
[...]
# Specify a maximum number of items to display in a dropdown.
#DROPDOWN_MAX_ITEMS = 30
[...]
</snip>
We need to maintain some script to modify it post-deployment/upgrade.

Hence, instead of hardcoding the parameter, please update the code so that we can manage it using heat templates and it will be consistent throughout the upgrade.

Fix proposed to branch: master
Review: https://review.openstack.org/633779

Changed in puppet-horizon:
assignee: nobody → Pratik Pravin Bandarkar (pratik-bandarkar)
status: New → In Progress
Changed in puppet-horizon:
assignee: Pratik Pravin Bandarkar (pratik-bandarkar) → Tobias Urdin (tobias-urdin)

Reviewed: https://review.opendev.org/633779
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=004142d577a1388244b19b2869797a4653b46bed
Submitter: Zuul
Branch: master

commit 004142d577a1388244b19b2869797a4653b46bed
Author: Pratik Bandarkar <email address hidden>
Date: Tue Jan 29 16:39:16 2019 +0000

    update "DROPDOWN_MAX_ITEMS" horizon parameter as a variable

    "DROPDOWN_MAX_ITEMS" horizon parameter was hardcoded in a ruby
    template. Hence, it was not possible to manage it using heat.
    This fix will allow user to manage "DROPDOWN_MAX_ITEMS" from
    heat template.

    Change-Id: I121a4ad2070cfef173c572a3d25788abbbf16989
    Closes-Bug: #1813786

Changed in puppet-horizon:
status: In Progress → Fix Released

This issue was fixed in the openstack/puppet-horizon 15.0.0 release.

Reviewed: https://review.opendev.org/722929
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=c399a6a5ce35e271492b92604e3a63ff161c1fe5
Submitter: Zuul
Branch: stable/rocky

commit c399a6a5ce35e271492b92604e3a63ff161c1fe5
Author: Pratik Bandarkar <email address hidden>
Date: Tue Jan 29 16:39:16 2019 +0000

    update "DROPDOWN_MAX_ITEMS" horizon parameter as a variable

    "DROPDOWN_MAX_ITEMS" horizon parameter was hardcoded in a ruby
    template. Hence, it was not possible to manage it using heat.
    This fix will allow user to manage "DROPDOWN_MAX_ITEMS" from
    heat template.

    Change-Id: I121a4ad2070cfef173c572a3d25788abbbf16989
    Closes-Bug: #1813786
    (cherry picked from commit 004142d577a1388244b19b2869797a4653b46bed)

tags: added: in-stable-rocky
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers