spec/fixtures is missing from the release tarball

Bug #1732262 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
High
Alex Schultz

Bug Description

Due to the way that the .gitignore is configured, the 'puppet module build' excludes files that are in .gitignore. This is a problem for puppet-horizon because we actually have files located in there that should be included. the spec/fixtures in the .gitignore should be adjusted for puppet-horizon to only exclude spec/fixtures/modules

summary: - spec/fixtures is missing from the release tarbal
+ spec/fixtures is missing from the release tarball
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/519735

Changed in puppet-horizon:
assignee: nobody → Alex Schultz (alex-schultz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (master)

Reviewed: https://review.openstack.org/519735
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=53e8a163d05f8531fad676da7d5dd61b9c651082
Submitter: Zuul
Branch: master

commit 53e8a163d05f8531fad676da7d5dd61b9c651082
Author: Alex Schultz <email address hidden>
Date: Tue Nov 14 13:01:57 2017 -0700

    Adjust fixtures .gitignore

    The .gitignore influences what files are include in a puppet module
    tarball. Since puppet-horizon has some test files that need to be
    included, we need to make sure that we don't completely exclude
    spec/fixtures. This change updates the module to just exclude
    spec/fixtures/modules which should not be shipped.

    Change-Id: Ia363a13f8a2be1f751c32c3a30ad5c4a5d352abf
    Closes-Bug: #1732262

Changed in puppet-horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/519819

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/519820

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/519821

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/newton)

Reviewed: https://review.openstack.org/519821
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=2d1a019e92423cc5fd4ed524bb06cbdb3fc06868
Submitter: Zuul
Branch: stable/newton

commit 2d1a019e92423cc5fd4ed524bb06cbdb3fc06868
Author: Alex Schultz <email address hidden>
Date: Tue Nov 14 13:01:57 2017 -0700

    Adjust fixtures .gitignore

    The .gitignore influences what files are include in a puppet module
    tarball. Since puppet-horizon has some test files that need to be
    included, we need to make sure that we don't completely exclude
    spec/fixtures. This change updates the module to just exclude
    spec/fixtures/modules which should not be shipped.

    Change-Id: Ia363a13f8a2be1f751c32c3a30ad5c4a5d352abf
    Closes-Bug: #1732262
    (cherry picked from commit 53e8a163d05f8531fad676da7d5dd61b9c651082)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/ocata)

Reviewed: https://review.openstack.org/519820
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=30df037392049d96d041285f3aa75c57f5e59277
Submitter: Zuul
Branch: stable/ocata

commit 30df037392049d96d041285f3aa75c57f5e59277
Author: Alex Schultz <email address hidden>
Date: Tue Nov 14 13:01:57 2017 -0700

    Adjust fixtures .gitignore

    The .gitignore influences what files are include in a puppet module
    tarball. Since puppet-horizon has some test files that need to be
    included, we need to make sure that we don't completely exclude
    spec/fixtures. This change updates the module to just exclude
    spec/fixtures/modules which should not be shipped.

    Change-Id: Ia363a13f8a2be1f751c32c3a30ad5c4a5d352abf
    Closes-Bug: #1732262
    (cherry picked from commit 53e8a163d05f8531fad676da7d5dd61b9c651082)

tags: added: in-stable-ocata
tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/pike)

Reviewed: https://review.openstack.org/519819
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=d8193fabb757367796eafe07629f40f1056578ea
Submitter: Zuul
Branch: stable/pike

commit d8193fabb757367796eafe07629f40f1056578ea
Author: Alex Schultz <email address hidden>
Date: Tue Nov 14 13:01:57 2017 -0700

    Adjust fixtures .gitignore

    The .gitignore influences what files are include in a puppet module
    tarball. Since puppet-horizon has some test files that need to be
    included, we need to make sure that we don't completely exclude
    spec/fixtures. This change updates the module to just exclude
    spec/fixtures/modules which should not be shipped.

    Change-Id: Ia363a13f8a2be1f751c32c3a30ad5c4a5d352abf
    Closes-Bug: #1732262
    (cherry picked from commit 53e8a163d05f8531fad676da7d5dd61b9c651082)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 11.4.0

This issue was fixed in the openstack/puppet-horizon 11.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 9.7.0

This issue was fixed in the openstack/puppet-horizon 9.7.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 10.5.0

This issue was fixed in the openstack/puppet-horizon 10.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.