Allow customization_module option to be set and managed in horizon config

Bug #1722653 reported by Lokesh Jain
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
Undecided
Lokesh Jain

Bug Description

Horizon has a global override mechanism available to perform customizations. This adds a key - customization_module - to HORIZON_CONFIG dictionary in local_settings.py. Currently there is no way to either set this value or expose it for configuration. This option needs to be added and exposed for users to configure. The value should be a string with the to the module containing modifications in dotted python path notation. The parameter should default to undef

Example:
customization_module => "my_project.overrides"

Changed in puppet-horizon:
status: New → In Progress
assignee: nobody → Lokesh Jain (lokesh-jain)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/511054

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (master)

Reviewed: https://review.openstack.org/511054
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=5657428cab4d79530b9cf1d347e94a51441a22eb
Submitter: Jenkins
Branch: master

commit 5657428cab4d79530b9cf1d347e94a51441a22eb
Author: Lokesh Jain <email address hidden>
Date: Tue Oct 10 17:34:07 2017 -0400

    Added customization-module option to Horizon config

    Horizon has a global override mechanism available to perform
    customizations. This change adds customization_module key
    to HORIZON_CONFIG dictionary in local_settings.py. The
    corresponding template file is also modified to configure the
    parameter. Spec tests are added to test the configuration.

    Change-Id: Id204b60b2676f49713fb6ce7eede6200221f7163
    Closes-Bug: #1722653

Changed in puppet-horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/511863

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/511875

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/511878

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/pike)

Reviewed: https://review.openstack.org/511863
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=1bcb0aa0b6959e3751c018532d8d5d44d5d4a2c4
Submitter: Jenkins
Branch: stable/pike

commit 1bcb0aa0b6959e3751c018532d8d5d44d5d4a2c4
Author: Lokesh Jain <email address hidden>
Date: Tue Oct 10 17:34:07 2017 -0400

    Added customization-module option to Horizon config

    Horizon has a global override mechanism available to perform
    customizations. This change adds customization_module key
    to HORIZON_CONFIG dictionary in local_settings.py. The
    corresponding template file is also modified to configure the
    parameter. Spec tests are added to test the configuration.

    Change-Id: Id204b60b2676f49713fb6ce7eede6200221f7163
    Closes-Bug: #1722653
    (cherry picked from commit 5657428cab4d79530b9cf1d347e94a51441a22eb)

tags: added: in-stable-pike
tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/ocata)

Reviewed: https://review.openstack.org/511875
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=cdbc03b259e18ca4a5e71923dfc8270f36cff61a
Submitter: Jenkins
Branch: stable/ocata

commit cdbc03b259e18ca4a5e71923dfc8270f36cff61a
Author: Lokesh Jain <email address hidden>
Date: Tue Oct 10 17:34:07 2017 -0400

    Added customization-module option to Horizon config

    Horizon has a global override mechanism available to perform
    customizations. This change adds customization_module key
    to HORIZON_CONFIG dictionary in local_settings.py. The
    corresponding template file is also modified to configure the
    parameter. Spec tests are added to test the configuration.

    Change-Id: Id204b60b2676f49713fb6ce7eede6200221f7163
    Closes-Bug: #1722653
    (cherry picked from commit 5657428cab4d79530b9cf1d347e94a51441a22eb)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/newton)

Reviewed: https://review.openstack.org/511878
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=6bb18e3e966e613f2da0c0b30a23d88d810b826e
Submitter: Jenkins
Branch: stable/newton

commit 6bb18e3e966e613f2da0c0b30a23d88d810b826e
Author: Lokesh Jain <email address hidden>
Date: Tue Oct 10 17:34:07 2017 -0400

    Added customization-module option to Horizon config

    Horizon has a global override mechanism available to perform
    customizations. This change adds customization_module key
    to HORIZON_CONFIG dictionary in local_settings.py. The
    corresponding template file is also modified to configure the
    parameter. Spec tests are added to test the configuration.

    Change-Id: Id204b60b2676f49713fb6ce7eede6200221f7163
    Closes-Bug: #1722653
    (cherry picked from commit 5657428cab4d79530b9cf1d347e94a51441a22eb)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 12.0.0

This issue was fixed in the openstack/puppet-horizon 12.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 11.4.0

This issue was fixed in the openstack/puppet-horizon 11.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 9.7.0

This issue was fixed in the openstack/puppet-horizon 9.7.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 10.5.0

This issue was fixed in the openstack/puppet-horizon 10.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.