Wrong rewrite rule when empty root_url

Bug #1665380 reported by Mateusz Kowalski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
Undecided
Mateusz Kowalski

Bug Description

When root_url is empty, apache vhost file is incorrect and causes httpd service to fail. The cause is an empty string inside Rewrite rule what is not allowed inside config file.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/434973

Changed in puppet-horizon:
assignee: nobody → Mateusz Kowalski (makowals)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (master)

Reviewed: https://review.openstack.org/434973
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=003d69f69cdebc5eadcac79890316dc82777e637
Submitter: Jenkins
Branch: master

commit 003d69f69cdebc5eadcac79890316dc82777e637
Author: Mateusz Kowalski <email address hidden>
Date: Thu Feb 16 14:56:07 2017 +0100

    Avoid empty redirect rule in vhost config

    When root_url is empty, an incorrect rewrite rule will be
    created at vhosts config file causing httpd failure.
    In order not to create any rule when root_url is empty,
    the value should be ignored inside redirectmatch parameter

    Change-Id: Idd4ac6a271b4c8d8e53ab27c68abd821a3aa0249
    Closes-bug: #1665380

Changed in puppet-horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 11.0.0

This issue was fixed in the openstack/puppet-horizon 11.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.