Set some extra_params like access_log_pipe failed

Bug #1653218 reported by Guillaume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
High
Unassigned

Bug Description

https://github.com/openstack/puppet-horizon/blob/master/manifests/wsgi/apache.pp#L242-L253
In wsgi/apache.pp $extra_params has a lower priority than the 3rd parameter in the merge(), that implies we can't overwrite any parameters we want and incompatible option like access_log_pipe cannot be set because access_log_file cannot be set to undef.

Guillaume (vatlas)
description: updated
description: updated
Changed in puppet-horizon:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Guillaume (vatlas) wrote :

I'd like to contribute to the repository, but I don't really know how I can do that so here is my patch.

Revision history for this message
Guillaume (vatlas) wrote :
Guillaume (vatlas)
Changed in puppet-horizon:
assignee: nobody → Guillaume (vatlas)
Changed in puppet-horizon:
assignee: Guillaume (vatlas) → nobody
Revision history for this message
Takashi Kajinami (kajinamit) wrote :

Recently we merged a few patches to make some hard-coded items configurable.
 https://review.opendev.org/c/openstack/puppet-horizon/+/841070
 https://review.opendev.org/c/openstack/puppet-horizon/+/841060

# Unfortunately I added a wrong bug id so these are not linked to this bug ...

I believe these two patches would cover most use cases (there are still some
hard-coded items but these are distro specific which we don't expect customization
about or are configurable by different parameters.

Changed in puppet-horizon:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.