Overriding ensure creates dulicate package error on python-memcache

Bug #1644906 reported by Lukas Bezdicka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
High
Lukas Bezdicka
puppet-oslo
Fix Released
High
Lukas Bezdicka

Bug Description

During tripleo update we override Package<||> {ensure => latest}, this yields error when used together with puppet-horizon. [1]

This is caused by ensure_packages defaulting to ensure => present see - [2]

I propose to switch both puppet-horizon and puppet-oslo ensure_package to ensure_resource without ensure allowing override in puppet-tripleo.

[1] - https://bugzilla.redhat.com/show_bug.cgi?id=1392583
[2] - https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/lib/puppet/parser/functions/ensure_packages.rb

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/403262

Changed in puppet-horizon:
assignee: nobody → Lukas Bezdicka (social-b)
status: New → In Progress
Changed in puppet-oslo:
assignee: nobody → Lukas Bezdicka (social-b)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-oslo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/403263

Changed in puppet-horizon:
importance: Undecided → High
Changed in puppet-oslo:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-oslo (master)

Reviewed: https://review.openstack.org/403263
Committed: https://git.openstack.org/cgit/openstack/puppet-oslo/commit/?id=e0b9dd93e21803eae8e9b52f458c563fe028b58f
Submitter: Jenkins
Branch: master

commit e0b9dd93e21803eae8e9b52f458c563fe028b58f
Author: Lukas Bezdicka <email address hidden>
Date: Fri Nov 25 20:42:56 2016 +0100

    Switch ensure_packages to ensure_resources for python-memcache

    The ensure_packages resource forces ensure to present yielding
    duplicate definition errors if we override default Package ensure
    to latest. We should solve this by using ensure_resources which
    does not enforce this.

    Change-Id: I1e2ba2b4a8ab31c925bf31ac1838999fc37b268f
    Closes-Bug: #1644906
    Resolves: rhbz#1392583

Changed in puppet-oslo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-oslo (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/404210

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (master)

Reviewed: https://review.openstack.org/403262
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=7cbcc78baa5ebe91d0dc990f5f1235a9ff2159e6
Submitter: Jenkins
Branch: master

commit 7cbcc78baa5ebe91d0dc990f5f1235a9ff2159e6
Author: Lukas Bezdicka <email address hidden>
Date: Fri Nov 25 20:35:39 2016 +0100

    Switch ensure_packages to ensure_resources for python-memcache

    The ensure_packages resource forces ensure to present yielding
    duplicate definition errors if we override default Package ensure
    to latest. We should solve this by using ensure_resources which
    does not enforce this.

    Change-Id: I1e2ba2b4a8ab31c925bf31ac1838999fc37b268f
    Closes-Bug: #1644906
    Resolves: rhbz#1392583

Changed in puppet-horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/404261

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-oslo (stable/newton)

Reviewed: https://review.openstack.org/404210
Committed: https://git.openstack.org/cgit/openstack/puppet-oslo/commit/?id=f2c1f2c69e2fa07e03580f18666eead44e868615
Submitter: Jenkins
Branch: stable/newton

commit f2c1f2c69e2fa07e03580f18666eead44e868615
Author: Lukas Bezdicka <email address hidden>
Date: Fri Nov 25 20:42:56 2016 +0100

    Switch ensure_packages to ensure_resources for python-memcache

    The ensure_packages resource forces ensure to present yielding
    duplicate definition errors if we override default Package ensure
    to latest. We should solve this by using ensure_resources which
    does not enforce this.

    Change-Id: I1e2ba2b4a8ab31c925bf31ac1838999fc37b268f
    Closes-Bug: #1644906
    Resolves: rhbz#1392583
    (cherry picked from commit e0b9dd93e21803eae8e9b52f458c563fe028b58f)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/newton)

Reviewed: https://review.openstack.org/404261
Committed: https://git.openstack.org/cgit/openstack/puppet-horizon/commit/?id=fa5028787413bcb31852cb5f3758a7bb89d0cded
Submitter: Jenkins
Branch: stable/newton

commit fa5028787413bcb31852cb5f3758a7bb89d0cded
Author: Lukas Bezdicka <email address hidden>
Date: Fri Nov 25 20:35:39 2016 +0100

    Switch ensure_packages to ensure_resources for python-memcache

    The ensure_packages resource forces ensure to present yielding
    duplicate definition errors if we override default Package ensure
    to latest. We should solve this by using ensure_resources which
    does not enforce this.

    Change-Id: I1e2ba2b4a8ab31c925bf31ac1838999fc37b268f
    Closes-Bug: #1644906
    Resolves: rhbz#1392583
    (cherry picked from commit 7cbcc78baa5ebe91d0dc990f5f1235a9ff2159e6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 10.1.0

This issue was fixed in the openstack/puppet-horizon 10.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-oslo 10.1.0

This issue was fixed in the openstack/puppet-oslo 10.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-horizon 9.5.0

This issue was fixed in the openstack/puppet-horizon 9.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-oslo 9.5.0

This issue was fixed in the openstack/puppet-oslo 9.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.