Updating webroot requires changes in _variables.scss

[Mathieu Gagné]

To update OpenStack dashboard webroot, one now needs to update the $webroot variable found in _variables.scss:

    $webroot: "/dashboard";

Otherwise icons won't appear in the interface.

This limitation of Horizon is already tracked in an upstream #1478794.

However, I believe we should still update _variables.scss with the appropriate value so our users have a better experience.

[Eric Peterson (ericpeterson-l)]

I believe this is no longer required with the introduction of this fix:

https://review.openstack.org/#/c/206592/

I'm not sure about the status of a backport fix, though

[Eric Peterson (ericpeterson-l)]

This is effectively the same thing from the puppet side:

https://github.com/openstack/puppet-horizon/blob/b975b22d97f5b794160bfdd5c4190990e8496331/manifests/params.pp#L17

[Eric Peterson (ericpeterson-l)]

One thing that might need to be done is this:

When you change the webroot variable, the puppet module might need re-collect static files and run the compressor (in case the url changed).

See the optional steps described at https://github.com/openstack/horizon/blob/master/doc/source/topics/install.rst (step 4 currently). It seems appropriate to have a notification for when the local settings changes, to re-run those two steps.

[Matt Fischer (mfisch)]

we should ask for a backport for horizon, it is fixed upstream.

[Takashi Kajinami (kajinamit)]

I'll mark this as Won't fix because the issue was resolved in Horizon itself by[1].

[1] https://review.opendev.org/c/openstack/horizon/+/206592

The webroot variable in included in local_settings thus any change of that parameter would trigger the compressor.