puppet-horizon

Policy files are in random order in local_settings.py

Bug #1422461 reported by Mathieu Gagné
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-horizon
Fix Released
High
Mathieu Gagné
puppet-horizon 6.0.0 "6.0.0"
Icehouse
Fix Committed
High
Mathieu Gagné
puppet-horizon 4.3.0 "4.3.0"
Juno
Fix Released
High
Mathieu Gagné
puppet-horizon 5.1.0 "5.1.0"

Bug Description

Hash order isn't preserved with Ruby 1.8.

This means local_settings.py might have a different content after each Puppet run due to policy files changing order.

We should sort them right before the output to avoid changes.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/156335

Changed in puppet-horizon:
assignee: nobody → Mathieu Gagné (mgagne)
status: New → In Progress
Mathieu Gagné (mgagne)
no longer affects: puppet-horizon/trunk
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (master)

Reviewed: https://review.openstack.org/156335
Committed: https://git.openstack.org/cgit/stackforge/puppet-horizon/commit/?id=915f0741adcd4becfa2f5156203a5c06a6cc62d6
Submitter: Jenkins
Branch: master

commit 915f0741adcd4becfa2f5156203a5c06a6cc62d6
Author: Mathieu Gagné <email address hidden>
Date: Mon Feb 16 14:00:20 2015 -0500

    Sort policy files in local_settings.py

    Hash order isn't preserved before Ruby 1.9.2.
    This change preserves the order for those running Ruby 1.8.

    Change-Id: I046a3e1c0b5efe5722d39ff91e01e94979204943
    Closes-bug: #1422461

Changed in puppet-horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/156814

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-horizon (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/156815

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/icehouse)

Reviewed: https://review.openstack.org/156815
Committed: https://git.openstack.org/cgit/stackforge/puppet-horizon/commit/?id=71e516fc351f2f33095ea4bd6635178a82c902d4
Submitter: Jenkins
Branch: stable/icehouse

commit 71e516fc351f2f33095ea4bd6635178a82c902d4
Author: Mathieu Gagné <email address hidden>
Date: Mon Feb 16 14:00:20 2015 -0500

    Sort policy files in local_settings.py

    Hash order isn't preserved before Ruby 1.9.2.
    This change preserves the order for those running Ruby 1.8.

    Change-Id: I046a3e1c0b5efe5722d39ff91e01e94979204943
    Closes-bug: #1422461
    (cherry picked from commit 915f0741adcd4becfa2f5156203a5c06a6cc62d6)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-horizon (stable/juno)

Reviewed: https://review.openstack.org/156814
Committed: https://git.openstack.org/cgit/stackforge/puppet-horizon/commit/?id=46f74e5576ccd4044328c619702721df012a0521
Submitter: Jenkins
Branch: stable/juno

commit 46f74e5576ccd4044328c619702721df012a0521
Author: Mathieu Gagné <email address hidden>
Date: Mon Feb 16 14:00:20 2015 -0500

    Sort policy files in local_settings.py

    Hash order isn't preserved before Ruby 1.9.2.
    This change preserves the order for those running Ruby 1.8.

    Change-Id: I046a3e1c0b5efe5722d39ff91e01e94979204943
    Closes-bug: #1422461
    (cherry picked from commit 915f0741adcd4becfa2f5156203a5c06a6cc62d6)

Mathieu Gagné (mgagne)
Changed in puppet-horizon:
milestone: none → 6.0.0
Emilien Macchi (emilienm)
Changed in puppet-horizon:
importance: Undecided → High
Mathieu Gagné (mgagne)
Changed in puppet-horizon:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.