Most of tests in init.pp tests aren't being executed

[Sergii Golovatiuk]

https://review.openstack.org/#/c/535696/1

rspec ignores the most of tests

How to reproduce:

# git clone https://git.openstack.org/openstack/puppet-heat && pushd puppet-heat
# cat << EOF | patch -R -p0
--- spec/classes/heat_init_spec.rb 2018-01-19 11:41:42.000000000 +0100
+++ spec/classes/heat_init_spec.rb.orig 2018-01-19 11:41:26.000000000 +0100
@@ -260,7 +260,7 @@
     end

     it 'should contain rabbit_ha_queues' do
- is_expected.to contain_heat_config('oslo_messaging_rabbit/rabbit_ha_queues').with_value('truee')
+ is_expected.to contain_heat_config('oslo_messaging_rabbit/rabbit_ha_queues').with_value('true')
     end
   end
EOF
# rake spec

[Bogdan Dobrelya (bogdando)]

I think this is rather a rspec or ruby bug, we can't do much to fix that until those dependencies resolved

[Jiří Stránský (jistr)]

The problem is likely that the heat_init_spec.rb defines a lot of "shared_examples_for" but it never uses the companion "it_should_behave_like" construct. Metaphorically speaking, that's like defining a function but never calling it.

For reference: https://stackoverflow.com/a/11058551/932311

[Takashi Kajinami (kajinamit)]

we no longer see this issue in current master, and I think it was fixed at some point...