Could not find resource 'Anchor[heat::db::begin]'

[Derek Higgins]

Tripleo-ci jobs started failing some time after 2200 UTC last night with the following error on the controll node

Oct 20 02:49:15 overcloud-controller-0 os-collect-config[2705]: [2015-10-20 01:49:15,021] (heat-config) [INFO] Warning: Variable access via 'notification_email_to' is deprecated. Use '@notification_email_to' ins
Oct 20 02:49:15 overcloud-controller-0 os-collect-config[2705]: (at /etc/puppet/modules/keepalived/templates/global_config.erb:3:in `block in result')
Oct 20 02:49:15 overcloud-controller-0 os-collect-config[2705]: Warning: notify is a metaparam; this value will inherit to all contained resources in the keepalived::instance definition
Oct 20 02:49:15 overcloud-controller-0 os-collect-config[2705]: Error: Could not find resource 'Anchor[heat::db::begin]' for relationship on 'Class[Heat::Db::Mysql]' on node overcloud-controller-0.localdomain
Oct 20 02:49:15 overcloud-controller-0 os-collect-config[2705]: Error: Could not find resource 'Anchor[heat::db::begin]' for relationship on 'Class[Heat::Db::Mysql]' on node overcloud-controller-0.localdomain
Oct 20 02:49:15 overcloud-controller-0 os-collect-config[2705]: [2015-10-20 01:49:15,021] (heat-config) [ERROR] Error running /var/lib/heat-config/heat-config-puppet/840526aa-469e-4b9a-87e8-286afe69f30f.pp. [1]
Oct 20 02:49:15 overcloud-controller-0 os-collect-config[2705]: [2015-10-20 01:49:15,025] (heat-config) [INFO] Completed /var/lib/heat-config/hooks/puppet

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/237466

[Derek Higgins (derekh)]

Looks like the anchor points that are failing were introduced in this commit
https://review.openstack.org/#/c/216926/3

[Derek Higgins (derekh)]

Testing a revert here
https://review.openstack.org/#/c/237466/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/237592

[OpenStack Infra (hudson-openstack)]

Change abandoned by Yanis Guenane (<email address hidden>) on branch: master
Review: https://review.openstack.org/237487

[OpenStack Infra (hudson-openstack)]

Change abandoned by Derek Higgins (<email address hidden>) on branch: master
Review: https://review.openstack.org/237466
Reason: Being fixed here
    https://review.openstack.org/#/c/237592/1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/237592
Committed: https://git.openstack.org/cgit/openstack/puppet-heat/commit/?id=dca9fe942b99b9c30e31167e4736058767738f21
Submitter: Jenkins
Branch: master

commit dca9fe942b99b9c30e31167e4736058767738f21
Author: Clayton O'Neill <email address hidden>
Date: Tue Oct 20 09:54:12 2015 -0400

    Move deps & external hooks into a standalone class

    Previously the anchors and dependencies that allow external hooks were
    all in the main ::heat class. However, if you wanted to include just
    ::heat::db::mysql, then it would fail, since it assumed the main heat
    class was included. This moves all of those resources and relationships
    into a new class, ::heat::deps. All of the classes will now include
    this class so that the anchors and deps are always evaluated even if
    only a portion of the classes are used, and even if ::heat isn't pulled
    in.

    Change-Id: I4297df160a7afae2b66c1ac76e37de313fa4fb09
    Closes-Bug: #1507934

[Ben Nemec (bnemec)]

Looks like this was fixed in the puppet module, so tripleo should be good now too.