top-level namespace methods cause collisions

[Michael Renner]

When using puppet-neutron in combination with puppet-heat this causes a collision with methods in the top-level namespace.

See

https://github.com/stackforge/puppet-neutron/blob/3de594dd8ca3ae39dce29f90a889361a85e70787/lib/puppet/provider/nova_admin_tenant_id_setter/ini_setting.rb#L74-104

https://github.com/stackforge/puppet-heat/blob/e68dc141cc559f88eb4bafdf2d5241b114e81fdb/lib/puppet/provider/heat_domain_id_setter/ruby.rb#L72-102

These providers should probably be moved to https://github.com/stackforge/puppet-openstacklib/tree/master/lib/puppet/provider

[Stefan Andres (s-andres)]

That bug leads to being unable to use heat::keystone::domain and neutron::server::notifications because both provider have different definitions which causes such things:

Error: /Stage[main]/Neutron::Server::Notifications/Nova_admin_tenant_id_setter[nova_admin_tenant_id]: Could not evaluate: Received error response from Keystone server at http://x.x.x.x:35357/v2.0/tenants: Unauthorized

[Colleen Murphy (krinkle)]

As a temporary workaround we could simply rename the methods in one of the providers, or they could be moved to within the scope of the provider.

[Emilien Macchi (emilienm)]

With all the refactorization we are doing to support both Keystone v2 & v3, I think we should wait until it lands in openstacklib, and refactor puppet-neutron & puppet-heat to use it.
It will avoid work duplication.

[Emilien Macchi (emilienm)]

https://review.openstack.org/#/c/162292/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/173544

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/173544
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=ccccfb97edcd28bb57e34464a4842555c39c06a6
Submitter: Jenkins
Branch: master

commit ccccfb97edcd28bb57e34464a4842555c39c06a6
Author: Emilien Macchi <email address hidden>
Date: Tue Apr 14 17:42:54 2015 -0400

    Rename handle_request to neutron_handle_request

    To avoid a future colision with other modules, we rename the
    handle_request method with a prefix (module name).

    Same patch in puppet-heat: https://review.openstack.org/#/c/162292/
    Closes-bug: #1429096

    Change-Id: If477dd15b1ffeb957481494a1da0b3e8ab29e299

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/162292
Committed: https://git.openstack.org/cgit/stackforge/puppet-heat/commit/?id=d73a719477806d2f9db18847fd2b84e41518daaa
Submitter: Jenkins
Branch: master

commit d73a719477806d2f9db18847fd2b84e41518daaa
Author: Emilien Macchi <email address hidden>
Date: Fri Mar 6 15:31:09 2015 -0500

    rename keystone_v2_authenticate method

    In puppet-neutron, keystone_v2_authenticate already exists and is in
    colision with the keystone_v2_authenticate in puppet-heat.

    While we move the whole method in puppet-openstacklib, let's just rename
    the method from keystone_v2_authenticate to keystone_v2_auth.

    Closes-bug #1429096

    Change-Id: I15b6d0550bb3baef37d7536d264b822768802ad0