Clients need to be added to rid of error messages

[Brad P. Crochet]

Mistral attempts to create actions based on clients that are installed. Errors can be seen here:

http://logs.openstack.org/60/534360/9/check/tripleo-ci-centos-7-undercloud-containers/e96445a/logs/undercloud/home/zuul/undercloud_install.log.txt.gz#_2018-01-19_17_32_23

If the client doesn't exist, the error reads: AttributeError: 'NoneType' object has no attribute 'Client'"

This is the case for Tacker, and Glare.

For keystone.oauth1, oauthlib needs to be installed.

We should install these things for convenience to the user, and to get rid of unwanted "errors", even though they don't truly affect the running of the system.

[Brad P. Crochet (brad-9)]

https://review.openstack.org/536903

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/536905

[Dougal Matthews (d0ugal)]

The fix here needs to be done in Mistral, there is work that has been in the pipeline (but has stalled) that would fix this.

The correct solution would be... Mistral wants to move the OpenStack actions to mistral-extra. This would then be configurable and would let users enable specific sets of actions. We would then only enable the OpenStack project actions that are relevant to a TripleO undercloud.

This wont happen for Queens, however, I think it could be a reasonable goal for Rocky if time can be assigned to it.

Having said that, there is a potential workaround if a fix is required sooner. Mistral can be given a custom mapping.json with only the actions we want to enable. At the moment it defaults to everything. https://github.com/openstack/mistral/blob/master/mistral/actions/openstack/mapping.json

[OpenStack Infra (hudson-openstack)]

Change abandoned by Brad P. Crochet (<email address hidden>) on branch: master
Review: https://review.openstack.org/536905

[Brad P. Crochet (brad-9)]

https://review.openstack.org/#/c/536886/ was also done to address this. It removes old client calls that no longer exist. I agree that the fix should probably be in Mistral, as opposed to adding unnecessary clients.

Should Mistral perhaps remove these less commonly used clients by default, and maybe have a default mapping.json that contains a smaller set and a 'full' mapping.json?