Typo in values for disk_format in glance_image

[Alexander Arzhanov]

Typo in vmd - newvalues(:ami, :ari, :aki, :vhd, :vmd, :raw, :qcow2, :vdi, :iso):
https://github.com/openstack/puppet-glance/blob/master/lib/puppet/type/glance_image.rb#L68
Correct disk_format vmdk, not vmd.

Logs:
Error: Parameter disk_format failed on Glance_image[TestVM-VMDK]: Invalid value "vmdk". Valid values are ami, ari, aki, vhd, vmd, raw, qcow2, vdi, iso.
/usr/lib/ruby/vendor_ruby/puppet/parameter/value_collection.rb:189:in `validate'
/usr/lib/ruby/vendor_ruby/puppet/parameter.rb:452:in `unsafe_validate'
/usr/lib/ruby/vendor_ruby/puppet/property.rb:591:in `unsafe_validate'
/usr/lib/ruby/vendor_ruby/puppet/parameter.rb:465:in `validate'
/usr/lib/ruby/vendor_ruby/puppet/property.rb:563:in `block in should='
/usr/lib/ruby/vendor_ruby/puppet/property.rb:563:in `each'
/usr/lib/ruby/vendor_ruby/puppet/property.rb:563:in `should='
/usr/lib/ruby/vendor_ruby/puppet/property.rb:615:in `value='
/usr/lib/ruby/vendor_ruby/puppet/type.rb:654:in `[]='
/usr/lib/ruby/vendor_ruby/puppet/type.rb:2272:in `block in set_parameters'
/usr/lib/ruby/vendor_ruby/puppet/type.rb:2266:in `each'
/usr/lib/ruby/vendor_ruby/puppet/type.rb:2266:in `set_parameters'
/usr/lib/ruby/vendor_ruby/puppet/type.rb:2222:in `initialize'
/usr/lib/ruby/vendor_ruby/puppet/resource.rb:349:in `new'
/usr/lib/ruby/vendor_ruby/puppet/resource.rb:349:in `to_ral'
/usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:520:in `block in to_catalog'
/usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:512:in `each'
/usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:512:in `to_catalog'
/usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:404:in `to_ral'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:225:in `block in main'
/usr/lib/ruby/vendor_ruby/puppet/context.rb:64:in `override'
/usr/lib/ruby/vendor_ruby/puppet.rb:246:in `override'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:198:in `main'
/usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:159:in `run_command'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:381:in `block (2 levels) in run'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:507:in `plugin_hook'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:381:in `block in run'
/usr/lib/ruby/vendor_ruby/puppet/util.rb:496:in `exit_on_fail'
/usr/lib/ruby/vendor_ruby/puppet/application.rb:381:in `run'
/usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:146:in `run'
/usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:92:in `execute'
/usr/bin/puppet:8:in `<main>'

[Alex Schultz (alex-schultz)]

Addressed by https://review.openstack.org/#/c/344857/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/344857
Committed: https://git.openstack.org/cgit/openstack/puppet-glance/commit/?id=804afb9c3ebe888e65e6ded5d13d32e6da780ae3
Submitter: Jenkins
Branch: master

commit 804afb9c3ebe888e65e6ded5d13d32e6da780ae3
Author: Alexander Arzhanov <email address hidden>
Date: Wed Jul 20 17:03:21 2016 +0300

    Fix typo in values for disk_format

    Fix typo in value vmd to vmdk.

    Closes-Bug: #1604829

    Change-Id: I0f2a3b7e37a3adbde7fdfaf91e518e0b97a40679

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/344979

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/345043

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/345043
Committed: https://git.openstack.org/cgit/openstack/puppet-glance/commit/?id=013343261dc8537151132d62c363bd7ccd5bd96e
Submitter: Jenkins
Branch: stable/liberty

commit 013343261dc8537151132d62c363bd7ccd5bd96e
Author: Alexander Arzhanov <email address hidden>
Date: Wed Jul 20 17:03:21 2016 +0300

    Fix typo in values for disk_format

    Fix typo in value vmd to vmdk.

    Closes-Bug: #1604829

    Change-Id: I0f2a3b7e37a3adbde7fdfaf91e518e0b97a40679
    (cherry picked from commit 804afb9c3ebe888e65e6ded5d13d32e6da780ae3)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/344979
Committed: https://git.openstack.org/cgit/openstack/puppet-glance/commit/?id=426864f3609fe059f4ae9ed442ee4e2320384e11
Submitter: Jenkins
Branch: stable/mitaka

commit 426864f3609fe059f4ae9ed442ee4e2320384e11
Author: Alexander Arzhanov <email address hidden>
Date: Wed Jul 20 17:03:21 2016 +0300

    Fix typo in values for disk_format

    Fix typo in value vmd to vmdk.

    Closes-Bug: #1604829

    Change-Id: I0f2a3b7e37a3adbde7fdfaf91e518e0b97a40679
    (cherry picked from commit 804afb9c3ebe888e65e6ded5d13d32e6da780ae3)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/puppet-glance 8.2.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-glance 9.2.0 release.