[service:api] max_header_line has no effect

Bug #1967825 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Undecided
Takashi Kajinami
puppet-designate
Fix Released
High
Takashi Kajinami

Bug Description

The following change removed reference to [service:api] max_header_line , and the parameter has had no effect since then.
 https://review.opendev.org/c/openstack/designate/+/678432

Because the same can be configured by [DEFAULT] max_header_line by oslo.service library, it's better we just remove the useless parameter.

Changed in designate:
assignee: nobody → Takashi Kajinami (kajinamit)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/designate/+/836423

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on designate (stable/train)

Change abandoned by "Takashi Kajinami <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/designate/+/836423

Changed in designate:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/designate/+/836424

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.opendev.org/c/openstack/designate/+/836424
Committed: https://opendev.org/openstack/designate/commit/1a4ace8a9adf1a938c7f465e8f5666fc8cd21c16
Submitter: "Zuul (22348)"
Branch: master

commit 1a4ace8a9adf1a938c7f465e8f5666fc8cd21c16
Author: Takashi Kajinami <email address hidden>
Date: Tue Apr 5 14:51:41 2022 +0900

    Deprecate ineffective [service:api] max_header_line

    This parmaeter has had no effect since [1] was merged. Because
    the parmaeter has been broken for several cycles and there has been
    the alternative parameter ([DEFAULT] max_header_line) to configure
    the same, this change makes the parameter for removal instead of fixing
    it.

    [1] a09064a5d15859703b97d61a1f014681a17799c6

    Closes-Bug: #1967825
    Change-Id: I04ea6b8132e6aee35eb72992273f63f3512d4aeb

Changed in designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-designate (master)
Changed in puppet-designate:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-designate (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-designate/+/842019
Committed: https://opendev.org/openstack/puppet-designate/commit/f39567e17b6e98a4cdf15608756a5463df32de39
Submitter: "Zuul (22348)"
Branch: master

commit f39567e17b6e98a4cdf15608756a5463df32de39
Author: Takashi Kajinami <email address hidden>
Date: Tue May 17 10:59:28 2022 +0900

    Fix ineffective max_header_line

    The [service:api] max_header_line parameter has had no effect since
    Train and it was effectively replaced by the [DEFAULT] max_header_line
    parameter provided by oslo.service.

    This updates the parameter definition accordingly.

    Closes-Bug: #1967825
    Change-Id: Ia969cc31b380950a87c0be0b911cc214b4219d82

Changed in puppet-designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/designate 15.0.0.0rc1

This issue was fixed in the openstack/designate 15.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-designate 21.0.0

This issue was fixed in the openstack/puppet-designate 21.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-designate (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/puppet-designate/+/865724

Changed in puppet-designate:
assignee: nobody → Takashi Kajinami (kajinamit)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-designate (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/puppet-designate/+/865724
Committed: https://opendev.org/openstack/puppet-designate/commit/bda94de190f55695072575295161381ab23c9002
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit bda94de190f55695072575295161381ab23c9002
Author: Takashi Kajinami <email address hidden>
Date: Tue May 17 10:59:28 2022 +0900

    Fix ineffective max_header_line

    The [service:api] max_header_line parameter has had no effect since
    Train and it was effectively replaced by the [DEFAULT] max_header_line
    parameter provided by oslo.service.

    This updates the parameter definition accordingly.

    Closes-Bug: #1967825
    Change-Id: Ia969cc31b380950a87c0be0b911cc214b4219d82
    (cherry picked from commit f39567e17b6e98a4cdf15608756a5463df32de39)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-designate (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-designate/+/866005

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-designate (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/puppet-designate/+/866005
Committed: https://opendev.org/openstack/puppet-designate/commit/062cc6c9816695adaddda6e8f172025a24bde300
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 062cc6c9816695adaddda6e8f172025a24bde300
Author: Takashi Kajinami <email address hidden>
Date: Tue May 17 10:59:28 2022 +0900

    Fix ineffective max_header_line

    The [service:api] max_header_line parameter has had no effect since
    Train and it was effectively replaced by the [DEFAULT] max_header_line
    parameter provided by oslo.service.

    This updates the parameter definition accordingly.

    Closes-Bug: #1967825
    Change-Id: Ia969cc31b380950a87c0be0b911cc214b4219d82
    (cherry picked from commit f39567e17b6e98a4cdf15608756a5463df32de39)
    (cherry picked from commit bda94de190f55695072575295161381ab23c9002)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-designate 19.5.0

This issue was fixed in the openstack/puppet-designate 19.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-designate 20.3.1

This issue was fixed in the openstack/puppet-designate 20.3.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.