Incorrect options configured for designate-central service

Bug #1539327 reported by Andrew Spiers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-designate
Fix Released
Undecided
Thomas Herve

Bug Description

central.pp configures options that are no longer used by designate, and does not configure options that are.

If I'm reading things right, the list of options that central can take are listed here:

https://github.com/openstack/designate/blob/stable/liberty/designate/central/__init__.py#L22

'workers',
 'threads',
'storage-driver',
 'enabled-notification-handlers',
'max_domain_name_len',
'max_recordset_name_len',
'managed_resource_email',
'managed_resource_tenant_id',
'min_ttl',
'default_pool_id',

options that the class configures are currently:
# [*backend_driver*]
# [*managed_resource_email*]
# [*managed_resource_tenant_id*]
# [*max_domain_name_len*]
# [*max_recordset_name_len*]
# [*min_ttl*]

Changed in puppet-designate:
assignee: nobody → Sharat Sharma (sharat-sharma)
Changed in puppet-designate:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/316691

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-designate (master)

Change abandoned by Sharat Sharma (<email address hidden>) on branch: master
Review: https://review.openstack.org/316691

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/379950

Changed in puppet-designate:
assignee: Sharat Sharma (sharat-sharma) → nobody
status: In Progress → New
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-designate (master)

Change abandoned by Sharat Sharma (<email address hidden>) on branch: master
Review: https://review.openstack.org/379950

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/518496

Changed in puppet-designate:
assignee: nobody → Thomas Herve (therve)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-designate (master)

Reviewed: https://review.openstack.org/518496
Committed: https://git.openstack.org/cgit/openstack/puppet-designate/commit/?id=74aee65cdfeae494c12e88bce5da4491a17fe2be
Submitter: Zuul
Branch: master

commit 74aee65cdfeae494c12e88bce5da4491a17fe2be
Author: Sharat Sharma <email address hidden>
Date: Fri Sep 30 11:43:32 2016 +0530

    Added options central service

    This patch adds workers, threads, default-pool-id options to the
    central.pp as these options can be configured for designate-central.

    Change-Id: I0635d5fd2ece7bca85fab772a055c999d6721c1a
    Closes-Bug: #1539327
    Co-Authored-By: Sharat Sharma <email address hidden>

Changed in puppet-designate:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-designate 12.1.0

This issue was fixed in the openstack/puppet-designate 12.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.