Type_set[$type] is executed at each puppet run

Bug #1354467 reported by Nicolas Hicher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-cinder
Fix Released
Medium
Nicolas Hicher
Icehouse
Fix Released
Undecided
Unassigned
Juno
Fix Released
Undecided
Unassigned

Bug Description

There is no check to create type-key only if it doesn't exist, so puppet will try to create the type-key at each run.

class cinder::type_set on debian system

Revision history for this message
Nicolas Hicher (nicolas-hicher-k) wrote :
description: updated
Revision history for this message
Nicolas Hicher (nicolas-hicher-k) wrote :

add spec patch

Changed in puppet-cinder:
status: New → Confirmed
assignee: nobody → Nicolas Hicher (nicolas-hicher-k)
importance: Undecided → Medium
Changed in puppet-cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (master)

Reviewed: https://review.openstack.org/112955
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=eea144eb8e8ce559b7f3aa4a233ccf0180fedcbd
Submitter: Jenkins
Branch: master

commit eea144eb8e8ce559b7f3aa4a233ccf0180fedcbd
Author: Nicolas Hicher <email address hidden>
Date: Fri Aug 8 11:53:03 2014 -0400

    Create type-key only if it doesn't exist

    * class cinder::type_set.pp
    * Add check to create type-key only if it doesn't exist

    Closes-Bug: #1354467

    Change-Id: If089bca0d784fc7bda6f76cd18f1ba29a82f2df2

Changed in puppet-cinder:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/162316

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/162317

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (stable/juno)

Reviewed: https://review.openstack.org/162316
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=330f7fd787e58024db885c77209dede57805332c
Submitter: Jenkins
Branch: stable/juno

commit 330f7fd787e58024db885c77209dede57805332c
Author: Nicolas Hicher <email address hidden>
Date: Fri Aug 8 11:53:03 2014 -0400

    Create type-key only if it doesn't exist

    * class cinder::type_set.pp
    * Add check to create type-key only if it doesn't exist

    Closes-Bug: #1354467

    Change-Id: If089bca0d784fc7bda6f76cd18f1ba29a82f2df2
    (cherry picked from commit eea144eb8e8ce559b7f3aa4a233ccf0180fedcbd)
    Co-Authored-By: Abel Lopez <email address hidden>

tags: added: in-stable-juno
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (stable/icehouse)

Reviewed: https://review.openstack.org/162317
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=973be65cf94583ad8a62ca19182a867a5da60079
Submitter: Jenkins
Branch: stable/icehouse

commit 973be65cf94583ad8a62ca19182a867a5da60079
Author: Nicolas Hicher <email address hidden>
Date: Fri Aug 8 11:53:03 2014 -0400

    Create type-key only if it doesn't exist

    * class cinder::type_set.pp
    * Add check to create type-key only if it doesn't exist

    Closes-Bug: #1354467

    Change-Id: If089bca0d784fc7bda6f76cd18f1ba29a82f2df2
    (cherry picked from commit eea144eb8e8ce559b7f3aa4a233ccf0180fedcbd)
    Co-Authored-By: Abel Lopez <email address hidden>

tags: added: in-stable-icehouse
Mathieu Gagné (mgagne)
Changed in puppet-cinder:
milestone: none → 6.0.0
Matt Fischer (mfisch)
Changed in puppet-cinder:
status: Fix Committed → Fix Released
Mathieu Gagné (mgagne)
Changed in puppet-cinder:
status: Fix Released → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-cinder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.