Attempt at restoring test volume's LVM loopback device causing new failure

[Alan Bishop]

Patch [1] was an attempt to restore the LVM test volume's loopback device when the node reboots. However, the fix was not reliable and the original LP bug [2] was reopened.

[1] https://review.openstack.org/465731
[2] https://launchpad.net/bugs/1581092

However, there are now reports that the code is triggering new fails when executed during TripleO's Fast Forward Upgrade (FFU) procedure. Here is an example of the failure as seen in the logs:

"Error: losetup -f /var/lib/cinder/cinder-volumes && udevadm settle && vgchange -a y cinder-volumes returned 5 instead of one of [0]",
"Error: /Stage[main]/Cinder::Setup_test_volume/Exec[losetup -f /var/lib/cinder/cinder-volumes && udevadm settle && vgchange -a y cinder-volumes]/returns: change from notrun to 0 failed: losetup -f /var/lib/cinder/cinder-volumes && udevadm settle && vgchange -a y cinder-volumes returned 5 instead of one of [0]",
"Warning: /Stage[main]/Cinder::Deps/Anchor[cinder::service::begin]: Skipping because of failed dependencies",
"Warning: /Stage[main]/Cinder::Volume/Service[cinder-volume]: Skipping because of failed dependencies",
"Warning: /Stage[main]/Tripleo::Profile::Base::Cinder::Volume::Iscs/Cinder::Backend::Iscsi[tripleo_iscsi]/Service[target]: Skipping because of failed dependencies",

The patch [1] should be reverted because it doesn't fix the original problem, and is now causing an additional problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/566056

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/566056
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=2761f8b1b9e16dfaee5fbaab5a29acfaa039b8b1
Submitter: Zuul
Branch: master

commit 2761f8b1b9e16dfaee5fbaab5a29acfaa039b8b1
Author: Alan Bishop <email address hidden>
Date: Thu May 3 08:58:19 2018 -0400

    Revert "Restore iscsi loopback LVM volume group on startup"

    This reverts commit b8f15088b5c3b70ae2c12ecd8185064a0159a6e1.

    The original commit failed to fully address the problem it tried
    to solve, and is causing additional problems.

    Closes-Bug: #1768833
    Change-Id: I9126e5acaf16a39528c65e756eb475dc62e1ab40
    Conflicts:
     manifests/setup_test_volume.pp

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/566349

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/566349
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=24fd4bd776d47ab956490ff555c7471cb01c0b99
Submitter: Zuul
Branch: stable/queens

commit 24fd4bd776d47ab956490ff555c7471cb01c0b99
Author: Alan Bishop <email address hidden>
Date: Thu May 3 08:58:19 2018 -0400

    Revert "Restore iscsi loopback LVM volume group on startup"

    This reverts commit b8f15088b5c3b70ae2c12ecd8185064a0159a6e1.

    The original commit failed to fully address the problem it tried
    to solve, and is causing additional problems.

    Closes-Bug: #1768833
    Change-Id: I9126e5acaf16a39528c65e756eb475dc62e1ab40
    Conflicts:
     manifests/setup_test_volume.pp
    (cherry picked from commit 2761f8b1b9e16dfaee5fbaab5a29acfaa039b8b1)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-cinder 12.4.1 release.