solidfire backend module doesn't handle svip correct

Bug #1605368 reported by Ed Balduf on 2016-07-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-cinder
Low
Ed Balduf

Bug Description

sf_svip should not have '' as defaults, but should have undef. This causes the sf_svip line to be put into the config file with '' and causes problems with the deployment. Should be as below. A fix will be submitted shortly.

diff --git a/manifests/backend/solidfire.pp b/manifests/backend/solidfire.pp
index 6517ad8..7d48b8d 100644
--- a/manifests/backend/solidfire.pp
+++ b/manifests/backend/solidfire.pp
@@ -89,7 +89,7 @@ define cinder::backend::solidfire(
   $sf_allow_template_caching = false,
   $sf_api_port = '443',
   $sf_volume_prefix = 'UUID-',
- $sf_svip = '',
+ $sf_svip = undef,
   $sf_enable_volume_mapping = true,
   $sf_enable_vag = false,
   $extra_options = {},

Ed Balduf (ebalduf) on 2016-07-21
Changed in puppet-cinder:
assignee: nobody → Ed Balduf (ebalduf)
assignee: Ed Balduf (ebalduf) → nobody
assignee: nobody → Ed Balduf (ebalduf)

Fix proposed to branch: master
Review: https://review.openstack.org/345632

Changed in puppet-cinder:
status: New → In Progress
Changed in puppet-cinder:
importance: Undecided → Wishlist
importance: Wishlist → Low

Reviewed: https://review.openstack.org/345632
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=18a914c353bf210c833d626b61f2fd50b6c4f4ee
Submitter: Jenkins
Branch: master

commit 18a914c353bf210c833d626b61f2fd50b6c4f4ee
Author: Ed Balduf <email address hidden>
Date: Fri Jul 22 14:56:15 2016 -0600

    SolidFire backend deployment should use $::os_service_default

    Fix SolidFire module to use $::os_service_default and update and
    enhance test coverage.

    Change-Id: Ide11259e1c55366837ff32ebcc3589e0e8e5a58b
    Closes-Bug: #1605368
    Closes-Bug: #1605373

Changed in puppet-cinder:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/347066
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=cada4f5d1792e767d08a8583032b9e06d52ae273
Submitter: Jenkins
Branch: stable/mitaka

commit cada4f5d1792e767d08a8583032b9e06d52ae273
Author: Ed Balduf <email address hidden>
Date: Fri Jul 22 14:56:15 2016 -0600

    SolidFire backend deployment should use $::os_service_default

    Fix SolidFire module to use $::os_service_default and update and
    enhance test coverage.

    Change-Id: Ide11259e1c55366837ff32ebcc3589e0e8e5a58b
    Closes-Bug: #1605368
    Closes-Bug: #1605373
    (cherry picked from commit 18a914c353bf210c833d626b61f2fd50b6c4f4ee)

tags: added: in-stable-mitaka

This issue was fixed in the openstack/puppet-cinder 9.2.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers