ontap_cluster backend fails with default value for netapp_eseries_host_type=linux_dm_mp

[Alfredo Moralejo]

Hi,

Some problems has been detected when working with ontap_cluster family type:

- Since liberty, netapp_eseries_host_type has been deprecatd to netapp_host_type:

https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/netapp/options.py#L171-L176

- Additionally, this parameters accepts different values depending on the family_type:

  - For eseries, it defaults to linux_dm_mp

https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/netapp/eseries/library.py#L115

  - For ontap_cluster, it defaults to 'linux' and linux_dm_mp is not a valid option. values acceptable are in:

https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/netapp/dataontap/block_base.py#L84-L86

Currently puppet-cinder defaults to linux_dm_mp which is invalid for ontap_cluster.

My suggestion would be to default netapp_host_type (or netapp_eseries_host_type) to null (as driver default since liberty) so that it picks the per-driver default and only pass a specific valued when a parameter is passed to cinder::backend::netapp.

Best regards,

Alfredo

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/318090

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/318090
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=8a29eb7b8d2e657067925e6a447cdf3895fc02a7
Submitter: Jenkins
Branch: master

commit 8a29eb7b8d2e657067925e6a447cdf3895fc02a7
Author: Arne Wiebalck <email address hidden>
Date: Wed May 18 14:35:40 2016 +0200

    NetApp: Use netapp_host_type

    This patch deprecates netapp_eseries_host_type in favor of
    netapp_host_type. As the default value for netapp_host_type is
    set to 'undef', per-driver defaults are picked if no values are
    passed to cinder::backend::netapp.

    Closes-Bug: #1579161
    Change-Id: I4c4dea024dbef08219641569ddec265e473e7b58

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-cinder 9.0.0 release.

[Attila Fazekas (afazekas)]

netapp_eseries_host_type also used by https://github.com/openstack/tripleo-heat-templates/blob/05691d25087e83066fbf5caadd022dca4c7131f2/puppet/extraconfig/pre_deploy/controller/cinder-netapp.yaml and https://github.com/openstack/tripleo-heat-templates/blob/05691d25087e83066fbf5caadd022dca4c7131f2/environments/cinder-netapp-config.yaml .

Which can cause the same issue.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/363955

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/363955
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=752394a111798adcf79b9329314558824f0d20b8
Submitter: Jenkins
Branch: master

commit 752394a111798adcf79b9329314558824f0d20b8
Author: Giulio Fidente <email address hidden>
Date: Wed Aug 31 23:32:40 2016 +0200

    Use netapp_host_type instead of netapp_eseries_host_type

    This patch deprecates netapp_eseries_host_type in favor of netapp_host_type.

    Change-Id: I113c770ca2e4dc54526d4262bacae48e223c54f4
    Closes-Bug: 1579161

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/381656

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/381656
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c79aacc58884d0d45d51cfeb2b419eadc03841e1
Submitter: Jenkins
Branch: stable/newton

commit c79aacc58884d0d45d51cfeb2b419eadc03841e1
Author: Giulio Fidente <email address hidden>
Date: Wed Aug 31 23:32:40 2016 +0200

    Use netapp_host_type instead of netapp_eseries_host_type

    This patch deprecates netapp_eseries_host_type in favor of netapp_host_type.

    Change-Id: I113c770ca2e4dc54526d4262bacae48e223c54f4
    Closes-Bug: 1579161
    (cherry picked from commit 752394a111798adcf79b9329314558824f0d20b8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0.0rc3 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 5.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0b1 development milestone.