puppet-cinder duplicate resource error

Bug #1526533 reported by craig
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-cinder
Fix Released
Medium
Matt Fischer

Bug Description

when using multiple ceph backends with different rbd_users the run fails with a duplicate resource on the ensure_resource file_line

Matt Fischer (mfisch)
Changed in puppet-cinder:
status: New → Confirmed
assignee: nobody → Matt Fischer (mfisch)
status: Confirmed → In Progress
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/258206

Revision history for this message
craig (craig-delatte) wrote :

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Error while evaluating a Function Call, Duplicate declaration: File_line[set initscript env] is already declared; cannot redeclare at /etc/puppet/environments/production/modules/cinder/manifests/backend/rbd.pp:109:3

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (master)

Reviewed: https://review.openstack.org/258206
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=3c4628281153a0ea0c6f2e713242f109ec3af83b
Submitter: Jenkins
Branch: master

commit 3c4628281153a0ea0c6f2e713242f109ec3af83b
Author: Matt Fischer <email address hidden>
Date: Tue Dec 15 14:38:31 2015 -0700

    Fix multiple rbd backend with multiple users

    If you have multiple rbd backends and each uses a different value for
    rbd_user you will get a duplicate resource. This solves that. There's no
    need for an ensure_resource line, just a unique name on the file_line is
    enough.

    Closes-Bug: #1526533

    Change-Id: I638630ce89fa332539aee03e6dd3057b36f78670

Changed in puppet-cinder:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/258729

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (stable/liberty)

Reviewed: https://review.openstack.org/258729
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=54cd5fdee50e05dab937ecac1c52588cccbf82c1
Submitter: Jenkins
Branch: stable/liberty

commit 54cd5fdee50e05dab937ecac1c52588cccbf82c1
Author: Matt Fischer <email address hidden>
Date: Tue Dec 15 14:38:31 2015 -0700

    Fix multiple rbd backend with multiple users

    If you have multiple rbd backends and each uses a different value for
    rbd_user you will get a duplicate resource. This solves that. There's no
    need for an ensure_resource line, just a unique name on the file_line is
    enough.

    Closes-Bug: #1526533

    Change-Id: I638630ce89fa332539aee03e6dd3057b36f78670
    (cherry picked from commit 3c4628281153a0ea0c6f2e713242f109ec3af83b)

tags: added: in-stable-liberty
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-cinder 7.1.0

This issue was fixed in the openstack/puppet-cinder 7.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.