Cinder::Type[iscsi]/Exec[cinder type-create iscsi]/returns: change from notrun to 0 failed: cinder type-create iscsi returned 1 instead of one of [0]

[meizhifang]

Install cinder, return "exec[cinder type-create iscsi]/returns: change from notrun to 0 failed: cinder type-create iscsi returned 1 instead of one of [0]".Then performed manually command "cinder type-create iscsi" ,return "ERROR: Conflict (HTTP 409) (Request-ID: req-0700f9e4-192c-49b6-8481-c979e1793af5)". In fact,if have values after execute cinder type-list ， should not execute exec[cinder type-create iscsi].The reason is wrong unless condition in exec[cinder type-create iscsi].
I suggest update cinder\manifests\type.pp from
  exec {"cinder type-create ${volume_name}":
    command => "cinder type-create ${volume_name}",
    unless => "cinder type-list | grep -qP '\\b${volume_name}\\b'",
    environment => concat($cinder_env, $region_env),
    require => Package['python-cinderclient'],
    path => ['/usr/bin', '/bin'],
  }
to
  exec {"cinder type-create ${volume_name}":
    command => "cinder type-create ${volume_name}",
    unless => "cinder type-list | grep -P '${volume_name}'",
    environment => concat($cinder_env, $region_env),
    require => Package['python-cinderclient'],
    path => ['/usr/bin', '/bin'],
  }

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/210944

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/210944
Reason: This review is > 4 weeks without comment or failed Jenkins or merge conflict the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Takashi Kajinami (kajinamit)]

The cinder::type class has been removed because of cinder_type resource.