puppet-cinder

Appended lines in cinder-volume.override

Bug #1284742 reported by Matthew J Black
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-cinder
Fix Released
Undecided
Matt Fischer
puppet-cinder 6.0.0 "6.0.0"

Bug Description

In the cinder-volume.override if the rbd user is changed the manifest will append a line in the file instead of replacing the line.

https://github.com/stackforge/puppet-cinder/blob/master/manifests/volume/rbd.pp#L90

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/152384

Changed in puppet-cinder:
assignee: nobody → Matt Fischer (mfisch)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (master)

Reviewed: https://review.openstack.org/152384
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=3641ea9547e2ba9fb5107e160e76b57d576a5cb3
Submitter: Jenkins
Branch: master

commit 3641ea9547e2ba9fb5107e160e76b57d576a5cb3
Author: Matt Fischer <email address hidden>
Date: Mon Feb 2 21:27:04 2015 -0700

    Don't add a new line if the rbd_user changes

    Change-Id: Iab8b1530ee349bd2c4143f82dfa2a26018eb8efa
    Closes-Bug: #1284742

Changed in puppet-cinder:
status: In Progress → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-cinder:
milestone: none → 6.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/187448

Matt Fischer (mfisch)
Changed in puppet-cinder:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-cinder (stable/juno)

Reviewed: https://review.openstack.org/187448
Committed: https://git.openstack.org/cgit/stackforge/puppet-cinder/commit/?id=869fa2edcd14dc30f078e58d84d73330e2b284cd
Submitter: Jenkins
Branch: stable/juno

commit 869fa2edcd14dc30f078e58d84d73330e2b284cd
Author: Matt Fischer <email address hidden>
Date: Mon Feb 2 21:27:04 2015 -0700

    Don't add a new line if the rbd_user changes

    Change-Id: Iab8b1530ee349bd2c4143f82dfa2a26018eb8efa
    Closes-Bug: #1284742
    (cherry picked from commit 3641ea9547e2ba9fb5107e160e76b57d576a5cb3)

tags: added: in-stable-juno
Mathieu Gagné (mgagne)
Changed in puppet-cinder:
status: Fix Released → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-cinder:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.