ceph-disk zap should be used instead of sgdisk to clean disks
Bug #1334229 reported by
David Gurtner
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| puppet-ceph |
Triaged
|
Medium
|
David Gurtner | ||
Bug Description
the use of sgdisk has multiple issues:
- it's not thorough enough and doesn't delete the backup GPT table at the end of a disk
- sgdisk is not normally installed, and it's availability in the integration tests is side effect that might be fixed in the future, breaking those tests.
The solution would be to change ceph::osd to use ceph-disk zap on removal of a disk, so we do not need to use sgdisk or zap anything ourselves anymore.
| Changed in puppet-ceph: | |
| assignee: | nobody → David Gurtner (aldavud) |
| status: | New → Triaged |
Revision history for this message
| Rod Smith (rodsmith) wrote | #1 |
| Changed in puppet-ceph: | |
| importance: | Undecided → Medium |
Revision history for this message
| Matt Fischer (mfisch) wrote | #2 |
To post a comment you must log in.
I don't know the context of how sgdisk is being called, but if you use its "-Z" option to wipe partition table data, sgdisk *DOES* delete the backup GPT data. If this is not working for you, I suggest you file a bug report against GPT fdisk. (I'm it's author; you can e-mail me at <email address hidden>.)