ceph-disk zap should be used instead of sgdisk to clean disks

Bug #1334229 reported by David Gurtner on 2014-06-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-ceph
Medium
David Gurtner

Bug Description

the use of sgdisk has multiple issues:

- it's not thorough enough and doesn't delete the backup GPT table at the end of a disk
- sgdisk is not normally installed, and it's availability in the integration tests is side effect that might be fixed in the future, breaking those tests.

The solution would be to change ceph::osd to use ceph-disk zap on removal of a disk, so we do not need to use sgdisk or zap anything ourselves anymore.

David Gurtner (aldavud) on 2014-06-25
Changed in puppet-ceph:
assignee: nobody → David Gurtner (aldavud)
status: New → Triaged
Rod Smith (rodsmith) wrote :

I don't know the context of how sgdisk is being called, but if you use its "-Z" option to wipe partition table data, sgdisk *DOES* delete the backup GPT data. If this is not working for you, I suggest you file a bug report against GPT fdisk. (I'm it's author; you can e-mail me at <email address hidden>.)

Changed in puppet-ceph:
importance: Undecided → Medium
Matt Fischer (mfisch) wrote :

David, is this still an issue? I can't find any references to sgdisk in the module or tests.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers