Possibility to disable service management

Bug #1359823 reported by Martin Mágr
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-ceilometer
Fix Released
Undecided
Martin Mágr
Icehouse
Fix Committed
Undecided
Unassigned
puppet-glance
Fix Released
Undecided
Martin Mágr
puppet-heat
Fix Released
Undecided
Martin Mágr
Icehouse
Fix Committed
Undecided
Unassigned
puppet-keystone
Fix Released
Undecided
Gael Chamoulaud
puppet-neutron
Fix Released
Undecided
Martin Mágr
Icehouse
Fix Committed
Undecided
Unassigned
puppet-swift
Fix Released
Undecided
Lukas Bezdicka
Icehouse
Fix Committed
Undecided
Unassigned
Juno
Fix Released
Undecided
Unassigned

Bug Description

This module does not support possibility to disable service management (service { '..': ensure=>undef}) as some other OpenStack-related modules do (puppet-cinder for example).

For HA deployment purposes this is required feature and should be implemented across all modules.

Martin Mágr (mmagr)
affects: puppet-heat → puppet-horizon
Changed in puppet-heat:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Changed in puppet-swift:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Changed in puppet-ceilometer:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116604

Changed in puppet-keystone:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Changed in puppet-horizon:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116610

Changed in puppet-glance:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Martin Mágr (mmagr)
description: updated
Revision history for this message
Martin Mágr (mmagr) wrote :

Also puppet-neutron has broken manage_service support in class neutron::agents::ovs. The only usable case is manage_service=>true. When using false you get following error:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find resource 'Service[ovs-cleanup-service]' for relationship from 'Package[neutron-plugin-ovs]' on node c1a2.example.com

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116933

Changed in puppet-neutron:
assignee: nobody → Martin Mágr (mmagr)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-neutron (master)

Reviewed: https://review.openstack.org/116933
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=e396f24b5d694b9dcf81f9d1dc9b95727af0a5ba
Submitter: Jenkins
Branch: master

commit e396f24b5d694b9dcf81f9d1dc9b95727af0a5ba
Author: Martin Magr <email address hidden>
Date: Tue Aug 26 17:54:12 2014 +0200

    Fixed manage_service feature

    Using manage_service=>false in class neutron::agents::ovs generates
    error. This patch is fixing the issue and makes mentioned use-case
    installable.

    Change-Id: I5a3205c3e21e1312463f47d938f5854a189c5d38
    Closes-bug: #1359823

Changed in puppet-neutron:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ceilometer (master)

Reviewed: https://review.openstack.org/115652
Committed: https://git.openstack.org/cgit/stackforge/puppet-ceilometer/commit/?id=10d38bd8191fc82f4087731ea6932583dd66db8d
Submitter: Jenkins
Branch: master

commit 10d38bd8191fc82f4087731ea6932583dd66db8d
Author: Martin Magr <email address hidden>
Date: Wed Aug 20 15:57:55 2014 +0200

    Add manage_service feature

    puppet-ceilometer lacks of disabling service managing. This patch adds
    $manage_service parameter to all relevant classes.

    Closes-bug: #1359823
    Change-Id: Iee545b46ef5d7cf92859356ae84b8103564bf047

Changed in puppet-ceilometer:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-glance (master)

Reviewed: https://review.openstack.org/116610
Committed: https://git.openstack.org/cgit/stackforge/puppet-glance/commit/?id=da217a13f5f3b1123a16566d7a3c2e69360b432b
Submitter: Jenkins
Branch: master

commit da217a13f5f3b1123a16566d7a3c2e69360b432b
Author: Martin Magr <email address hidden>
Date: Mon Aug 25 15:15:55 2014 +0200

    Add manage_service feature

    puppet-glance lacks of disabling service managing. This patch adds
    $manage_service parameter to relevant classes.

    Change-Id: I222b1a3318f5163f6ad1e39cbb8be10c440ab99f
    Closes-bug: #1359823

Changed in puppet-glance:
status: In Progress → Fix Committed
Changed in puppet-heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-heat (master)

Reviewed: https://review.openstack.org/115694
Committed: https://git.openstack.org/cgit/stackforge/puppet-heat/commit/?id=2ee54962a8132065ea9f8558bcb7cdfd39f946bd
Submitter: Jenkins
Branch: master

commit 2ee54962a8132065ea9f8558bcb7cdfd39f946bd
Author: Martin Magr <email address hidden>
Date: Wed Aug 20 18:03:45 2014 +0200

    Add manage_service feature

    puppet-heat lacks of disabling service managing. This patch adds
    $manage_service parameter to all relevant classes.

    Closes-bug: #1359823
    Change-Id: I54245b39f3484ccdb9910aa0fa4c8dc2bae3f0ce

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-horizon (master)

Change abandoned by Martin M?gr (<email address hidden>) on branch: master
Review: https://review.openstack.org/115690
Reason: Reconsidered this change and I think class ::apache is has to be defined by include style instead of class style. Also not managing httpd by puppet-horizon can be implemented using by parameter configure_apache.

Martin Mágr (mmagr)
no longer affects: puppet-horizon
Changed in puppet-swift:
assignee: Martin Mágr (mmagr) → Sebastien Badia (sbadia)
Changed in puppet-swift:
assignee: Sebastien Badia (sbadia) → Lukas Bezdicka (social-b)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.openstack.org/115659
Committed: https://git.openstack.org/cgit/stackforge/puppet-swift/commit/?id=22f09aed4f3c93a0d06ed1884b90dcaede60a6f7
Submitter: Jenkins
Branch: master

commit 22f09aed4f3c93a0d06ed1884b90dcaede60a6f7
Author: Martin Mágr <email address hidden>
Date: Mon Sep 22 15:50:38 2014 +0200

    Add manage_service feature

    puppet-swift lacks of disabling service managing. This patch adds
    $manage_service and $enabled parameter to all relevant classes.

    Closes-bug: #1359823
    Change-Id: I3d632e3a26e9394d03d94089ae704904bf77aa51

Changed in puppet-swift:
status: In Progress → Fix Committed
Changed in puppet-keystone:
assignee: Martin Mágr (mmagr) → Gael Chamoulaud (gael-chamoulaud)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-ceilometer (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/156964

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-heat (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/156965

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/156967

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/156969

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-glance (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/156971

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-neutron (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/156973

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/juno)

Reviewed: https://review.openstack.org/156967
Committed: https://git.openstack.org/cgit/stackforge/puppet-swift/commit/?id=bcf62347345082f90406d1b27ae1f8675b39bed5
Submitter: Jenkins
Branch: stable/juno

commit bcf62347345082f90406d1b27ae1f8675b39bed5
Author: Martin Mágr <email address hidden>
Date: Mon Sep 22 15:50:38 2014 +0200

    Add manage_service feature

    puppet-swift lacks of disabling service managing. This patch adds
    $manage_service and $enabled parameter to all relevant classes.

    Closes-bug: #1359823
    Change-Id: I3d632e3a26e9394d03d94089ae704904bf77aa51
    (cherry picked from commit 22f09aed4f3c93a0d06ed1884b90dcaede60a6f7)

tags: added: in-stable-juno
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ceilometer (stable/icehouse)

Reviewed: https://review.openstack.org/156964
Committed: https://git.openstack.org/cgit/stackforge/puppet-ceilometer/commit/?id=82095a17ae30d6d545f91bf2db575f949637972a
Submitter: Jenkins
Branch: stable/icehouse

commit 82095a17ae30d6d545f91bf2db575f949637972a
Author: Martin Magr <email address hidden>
Date: Wed Aug 20 15:57:55 2014 +0200

    Add manage_service feature

    puppet-ceilometer lacks of disabling service managing. This patch adds
    $manage_service parameter to all relevant classes.

    Closes-bug: #1359823
    Change-Id: Iee545b46ef5d7cf92859356ae84b8103564bf047
    (cherry picked from commit 10d38bd8191fc82f4087731ea6932583dd66db8d)

tags: added: in-stable-icehouse
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/icehouse)

Reviewed: https://review.openstack.org/156969
Committed: https://git.openstack.org/cgit/stackforge/puppet-swift/commit/?id=6b7d97c1bbfd076a51195c80043e187ee4b6313c
Submitter: Jenkins
Branch: stable/icehouse

commit 6b7d97c1bbfd076a51195c80043e187ee4b6313c
Author: Martin Mágr <email address hidden>
Date: Mon Sep 22 15:50:38 2014 +0200

    Add manage_service feature

    puppet-swift lacks of disabling service managing. This patch adds
    $manage_service and $enabled parameter to all relevant classes.

    Closes-bug: #1359823
    Change-Id: I3d632e3a26e9394d03d94089ae704904bf77aa51
    (cherry picked from commit 22f09aed4f3c93a0d06ed1884b90dcaede60a6f7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-heat (stable/icehouse)

Reviewed: https://review.openstack.org/156965
Committed: https://git.openstack.org/cgit/stackforge/puppet-heat/commit/?id=e015ff5598f905d8cf21f0a662d1df82e5347acc
Submitter: Jenkins
Branch: stable/icehouse

commit e015ff5598f905d8cf21f0a662d1df82e5347acc
Author: Martin Magr <email address hidden>
Date: Wed Aug 20 18:03:45 2014 +0200

    Add manage_service feature

    puppet-heat lacks of disabling service managing. This patch adds
    $manage_service parameter to all relevant classes.

    Closes-bug: #1359823
    Change-Id: I54245b39f3484ccdb9910aa0fa4c8dc2bae3f0ce
    (cherry picked from commit 2ee54962a8132065ea9f8558bcb7cdfd39f946bd)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-neutron (stable/icehouse)

Reviewed: https://review.openstack.org/156973
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=cd6e416d6424e1289741bf92171288fe57eec971
Submitter: Jenkins
Branch: stable/icehouse

commit cd6e416d6424e1289741bf92171288fe57eec971
Author: Martin Magr <email address hidden>
Date: Tue Aug 26 17:54:12 2014 +0200

    Fixed manage_service feature

    Using manage_service=>false in class neutron::agents::ovs generates
    error. This patch is fixing the issue and makes mentioned use-case
    installable.

    Change-Id: I5a3205c3e21e1312463f47d938f5854a189c5d38
    Closes-bug: #1359823
    (cherry picked from commit e396f24b5d694b9dcf81f9d1dc9b95727af0a5ba)

Changed in puppet-keystone:
assignee: Gael Chamoulaud (gael-chamoulaud) → Lukas Bezdicka (social-b)
Changed in puppet-keystone:
assignee: Lukas Bezdicka (social-b) → Gael Chamoulaud (gael-chamoulaud)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (master)

Reviewed: https://review.openstack.org/116604
Committed: https://git.openstack.org/cgit/stackforge/puppet-keystone/commit/?id=0ca426fa058161e6adbd9544136dc71af6f43808
Submitter: Jenkins
Branch: master

commit 0ca426fa058161e6adbd9544136dc71af6f43808
Author: Martin Magr <email address hidden>
Date: Mon Aug 25 14:52:37 2014 +0200

    Add manage_service feature

    puppet-keystone lacks of disabling service managing. This patch adds
    $manage_service parameter to relevant class.

    Change-Id: I80a55857442c6cd32387481fbe68b54f52e827a1
    Closes-bug: #1359823

Changed in puppet-keystone:
status: In Progress → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-heat:
milestone: none → 5.0.0
Changed in puppet-glance:
milestone: none → 5.0.0
Changed in puppet-ceilometer:
milestone: none → 5.0.0
Changed in puppet-neutron:
milestone: none → 5.0.0
Changed in puppet-keystone:
milestone: none → 6.0.0
Changed in puppet-ceilometer:
status: Fix Committed → Fix Released
Changed in puppet-glance:
status: Fix Committed → Fix Released
Changed in puppet-heat:
status: Fix Committed → Fix Released
Changed in puppet-neutron:
status: Fix Committed → Fix Released
Changed in puppet-swift:
milestone: none → 6.0.0
Matt Fischer (mfisch)
Changed in puppet-keystone:
status: Fix Committed → Fix Released
Mathieu Gagné (mgagne)
Changed in puppet-keystone:
status: Fix Released → Fix Committed
Mathieu Gagné (mgagne)
Changed in puppet-keystone:
status: Fix Committed → Fix Released
Changed in puppet-swift:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-glance (stable/icehouse)

Change abandoned by Lukas Bezdicka (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/156971

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.