[newton/ocata] specifying multiple dispatchers shouldn't just concatenate them

Bug #1737418 reported by David Vallee Delisle
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-ceilometer
Fix Released
Undecided
Mehdi Abaakouk

Bug Description

This bug is a complement of this one [1]. If we specify multiple event or metric dispatchers, they should be added on different lines.

When using the following template:

ceilometer::collector::event_dispatcher: ['gnocchi', 'database']

We get this:
event_dispatchers=gnocchi,database

But we should get this:
event_dispatchers=gnocchi
event_dispatchers=database

Same for the metric_dispatchers.

The problem seems to be in this file [2].

[1] https://review.openstack.org/#/c/521132/
[2] https://github.com/openstack/puppet-ceilometer/blob/stable/newton/manifests/collector.pp

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-ceilometer (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/527017

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ceilometer (stable/newton)

Reviewed: https://review.openstack.org/527017
Committed: https://git.openstack.org/cgit/openstack/puppet-ceilometer/commit/?id=ebdd3cdf029ac3eff4b7c8b552fa6484b98a82fb
Submitter: Zuul
Branch: stable/newton

commit ebdd3cdf029ac3eff4b7c8b552fa6484b98a82fb
Author: Pradeep Kilambi <email address hidden>
Date: Tue Apr 4 15:55:43 2017 -0400

    Fix dispatcher params

    Currently we join the params and pass in a string to the dispatcher
    settings. This wont work as ceilometer config expects separate
    lines for each value.

    (cherry picked from commit a791baa616668e8b7ce12e49d7f918a52293b74f)
    (cherry picked from commit 22abe647e6c54c8877245912d35da44a694edf04)
    Closes-bug: #1737418
    Change-Id: I3813f0918c8394ef14959be7580bf026314ba82e

tags: added: in-stable-newton
zhongshengping (chdzsp)
Changed in puppet-ceilometer:
status: New → Fix Released
assignee: nobody → zhongshengping (chdzsp)
assignee: zhongshengping (chdzsp) → nobody
assignee: nobody → David Vallee Delisle (valleedelisle)
assignee: David Vallee Delisle (valleedelisle) → Mehdi Abaakouk (sileht)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-ceilometer 9.6.0

This issue was fixed in the openstack/puppet-ceilometer 9.6.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.