new ceilometer-api package includes apache configuration leading to beaker failures on the 2nd run

[Alex Schultz]

The ceilometer-api package includes an apache configuration for /etc/apache2/sites-avilable/ceilometer-api.conf. If we configure apache prior to this package installation, the sites-available file gets removed on the second run. We need to make sure that we install the package prior to the configuration of apache so that we're cleaning up this file on the first run.

2017-01-17 22:35:02.000047 | Failures:
2017-01-17 22:35:02.000058 |
2017-01-17 22:35:02.000085 | 1) ceilometer with mysql default parameters should work with no errors
2017-01-17 22:35:02.000110 | Failure/Error: apply_manifest(pp, :catch_changes => true)
2017-01-17 22:35:02.000134 | Beaker::Host::CommandFailure:
2017-01-17 22:35:02.000162 | Host 'ubuntu-16.04-amd64' exited with 2 running:
2017-01-17 22:35:02.000212 | puppet apply --verbose --detailed-exitcodes /tmp/apply_manifest.pp.ORLHOA
2017-01-17 22:35:02.000245 | Last 10 lines of output were:
2017-01-17 22:35:02.000279 | Info: Applying configuration version '1484692440'
2017-01-17 22:35:02.000314 | Info: Computing checksum on file /etc/apache2/sites-available/ceilometer-api.conf
2017-01-17 22:35:02.000385 | Info: /Stage[main]/Apache/File[/etc/apache2/sites-available/ceilometer-api.conf]: Filebucketed /etc/apache2/sites-available/ceilometer-api.conf to puppet with sum d589815578f21f028dec47dce5aa5716
2017-01-17 22:35:02.000424 | Notice: /Stage[main]/Apache/File[/etc/apache2/sites-available/ceilometer-api.conf]/ensure: removed
2017-01-17 22:35:02.000458 | Info: /etc/apache2/sites-available: Scheduling refresh of Class[Apache::Service]
2017-01-17 22:35:02.000518 | Notice: /Stage[main]/Apache/File[/etc/apache2/sites-enabled/ceilometer-api.conf]/ensure: removed
2017-01-17 22:35:02.000569 | Info: /etc/apache2/sites-enabled: Scheduling refresh of Class[Apache::Service]
2017-01-17 22:35:02.000604 | Info: Class[Apache::Service]: Scheduling refresh of Service[httpd]
2017-01-17 22:35:02.000639 | Notice: /Stage[main]/Apache::Service/Service[httpd]: Triggered 'refresh' from 1 events
2017-01-17 22:35:02.000661 | Notice: Applied catalog in 55.04 seconds
2017-01-17 22:35:02.000670 |
2017-01-17 22:35:02.000697 | # ./.bundled_gems/gems/beaker-2.51.0/lib/beaker/host.rb:351:in `exec'
2017-01-17 22:35:02.000732 | # ./.bundled_gems/gems/beaker-2.51.0/lib/beaker/dsl/helpers/host_helpers.rb:83:in `block in on'
2017-01-17 22:35:02.000765 | # ./.bundled_gems/gems/beaker-2.51.0/lib/beaker/shared/host_manager.rb:127:in `run_block_on'
2017-01-17 22:35:02.000795 | # ./.bundled_gems/gems/beaker-2.51.0/lib/beaker/dsl/patterns.rb:37:in `block_on'
2017-01-17 22:35:02.000827 | # ./.bundled_gems/gems/beaker-2.51.0/lib/beaker/dsl/helpers/host_helpers.rb:63:in `on'
2017-01-17 22:35:02.000866 | # ./.bundled_gems/gems/beaker-2.51.0/lib/beaker/dsl/helpers/puppet_helpers.rb:480:in `block in apply_manifest_on'
2017-01-17 22:35:02.000908 | # ./.bundled_gems/gems/beaker-2.51.0/lib/beaker/shared/host_manager.rb:127:in `run_block_on'
2017-01-17 22:35:02.000939 | # ./.bundled_gems/gems/beaker-2.51.0/lib/beaker/dsl/patterns.rb:37:in `block_on'
2017-01-17 22:35:02.000975 | # ./.bundled_gems/gems/beaker-2.51.0/lib/beaker/dsl/helpers/puppet_helpers.rb:409:in `apply_manifest_on'
2017-01-17 22:35:02.001011 | # ./.bundled_gems/gems/beaker-2.51.0/lib/beaker/dsl/helpers/puppet_helpers.rb:487:in `apply_manifest'
2017-01-17 22:35:02.001048 | # ./spec/acceptance/ceilometer_wsgi_apache_spec.rb:70:in `block (3 levels) in <top (required)>'
2017-01-17 22:35:02.001056 |

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/421561
Committed: https://git.openstack.org/cgit/openstack/puppet-ceilometer/commit/?id=306c6d660d49ed71419cae534e52935e1e1069c5
Submitter: Jenkins
Branch: master

commit 306c6d660d49ed71419cae534e52935e1e1069c5
Author: Alex Schultz <email address hidden>
Date: Tue Jan 17 15:22:53 2017 -0700

    Fix Ubuntu Ocata issues

    The Ubuntu libvirt package has been updated for Ocata and includes
    the Debian name for the libvirt group now. This change updates the
    libvirt group to be 'libvirt' and not 'libvirtd' as it was previously.

    Additionally, we are not properly waiting for the ceilometer packages to
    be installed before attempting to configure apache which under Ubuntu
    can lead to a non-idempotent 2nd run if the apache configuration file
    is installed after we've already run our apache configuration.

    Change-Id: Id191d1a12c84a2bdb305630fd7b10516ac2ba0c2
    Closes-Bug: #1657291
    Closes-Bug: #1657309

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ceilometer 10.2.0 release.