Defaults for *::db classes are incorrect

Bug #1515273 reported by Clayton O'Neill
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-aodh
Fix Released
High
Denis Egorenko
puppet-barbican
Fix Released
High
Iury Gregory Melo Ferreira
puppet-ceilometer
Fix Released
High
Iury Gregory Melo Ferreira
puppet-gnocchi
Fix Released
High
Gael Chamoulaud
puppet-heat
Fix Released
High
Nikita Karpin
puppet-ironic
Fix Released
High
Iury Gregory Melo Ferreira
puppet-keystone
Fix Released
High
Iury Gregory Melo Ferreira
puppet-manila
Fix Released
High
Iury Gregory Melo Ferreira
puppet-murano
Fix Released
High
Denis Egorenko
puppet-neutron
Fix Released
High
Sergey Kolekonov
puppet-nova
Fix Released
High
Iury Gregory Melo Ferreira
puppet-sahara
Fix Released
High
Denis Egorenko
puppet-tuskar
Fix Released
High
Denis Egorenko

Bug Description

All of the modules now have or are getting a standard <modulename>::db class that accepts parameters that are passed on to oslo_db. However, these new classes are setting default values for database/max_pool_size and database/max_overflow.

These config keys have no default value in oslo_db, and instead use the defaults in sqlalchemy:
https://github.com/openstack/oslo.db/blob/master/oslo_db/options.py#L70-L76 and https://github.com/openstack/oslo.db/blob/master/oslo_db/options.py#L93-L99

SQL alchemy's defaults are pool class dependent, but it appears that oslo_db will always use the QueuePool. You can find the documentation for the QueuePool class here (http://docs.sqlalchemy.org/en/latest/core/pooling.html#api-documentation-available-pool-implementations) and look at the pool_size and max_overflow parameters. These default to 5 and 10 respectively, but the Puppet modules are now changing the default to 10 and 20, doubling the defaults.

Changed in puppet-tuskar:
assignee: nobody → Denis Egorenko (degorenko)
Changed in puppet-sahara:
assignee: nobody → Denis Egorenko (degorenko)
Changed in puppet-murano:
assignee: nobody → Denis Egorenko (degorenko)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-tuskar (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/246541

Changed in puppet-tuskar:
importance: Undecided → High
Changed in puppet-aodh:
importance: Undecided → High
Changed in puppet-barbican:
importance: Undecided → High
Changed in puppet-ceilometer:
importance: Undecided → High
Changed in puppet-gnocchi:
importance: Undecided → High
Changed in puppet-heat:
importance: Undecided → High
Changed in puppet-ironic:
importance: Undecided → High
Changed in puppet-keystone:
importance: Undecided → High
Changed in puppet-manila:
importance: Undecided → High
Changed in puppet-murano:
importance: Undecided → High
Changed in puppet-neutron:
importance: Undecided → High
Changed in puppet-nova:
importance: Undecided → High
Changed in puppet-sahara:
importance: Undecided → High
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

Note, there is a $::os_service_default and is_service_default() things now called to help to fix this issue across all of the PO modules. With a nice bonus as a drastic decrease of code to support :)

Changed in puppet-tuskar:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-murano (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/247482

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-tuskar (master)

Reviewed: https://review.openstack.org/246541
Committed: https://git.openstack.org/cgit/openstack/puppet-tuskar/commit/?id=12849acc6660b64ba8073f3db9be3723e786c75e
Submitter: Jenkins
Branch: master

commit 12849acc6660b64ba8073f3db9be3723e786c75e
Author: Denis Egorenko <email address hidden>
Date: Tue Nov 17 21:25:11 2015 +0300

    Switch Tuskar to $::os_service_default

    Switch Tuskar params to $::os_service_default fact

    Change-Id: I94dcec31f04937374d096ff732c872439580772b
    Related-bug: #1515273

Changed in puppet-keystone:
assignee: nobody → Iury Gregory Melo Ferreira (iurygregory)
Changed in puppet-aodh:
assignee: nobody → Gael Chamoulaud (gael-chamoulaud)
Changed in puppet-gnocchi:
assignee: nobody → Gael Chamoulaud (gael-chamoulaud)
assignee: Gael Chamoulaud (gael-chamoulaud) → nobody
Changed in puppet-aodh:
assignee: Gael Chamoulaud (gael-chamoulaud) → nobody
assignee: nobody → Gael Chamoulaud (gael-chamoulaud)
Changed in puppet-gnocchi:
assignee: nobody → Gael Chamoulaud (gael-chamoulaud)
Changed in puppet-heat:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-neutron:
assignee: nobody → Sergey Kolekonov (skolekonov)
Changed in puppet-nova:
assignee: nobody → Iury Gregory Melo Ferreira (iurygregory)
Changed in puppet-ceilometer:
assignee: nobody → Iury Gregory Melo Ferreira (iurygregory)
Changed in puppet-ironic:
assignee: nobody → Iury Gregory Melo Ferreira (iurygregory)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-nova (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/248901

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-heat (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/249119

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-ironic (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/249274

Changed in puppet-nova:
status: New → In Progress
Changed in puppet-keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-ceilometer (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/249377

Changed in puppet-manila:
assignee: nobody → Iury Gregory Melo Ferreira (iurygregory)
Changed in puppet-ironic:
status: New → In Progress
Changed in puppet-manila:
status: New → In Progress
Changed in puppet-ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-manila (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/249394

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-barbican (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/249401

Changed in puppet-barbican:
assignee: nobody → Iury Gregory Melo Ferreira (iurygregory)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-murano (master)

Reviewed: https://review.openstack.org/247482
Committed: https://git.openstack.org/cgit/openstack/puppet-murano/commit/?id=fafba4933742e4bf483c86ca55b471741e763efe
Submitter: Jenkins
Branch: master

commit fafba4933742e4bf483c86ca55b471741e763efe
Author: Denis Egorenko <email address hidden>
Date: Thu Nov 19 15:58:59 2015 +0300

    Switch Murano to use $::os_service_default fact

    This patch switches Murano to use $::os_service_default fact as
    default value for params instead of using deplicated defaults from
    project

    Change-Id: Ie5d669bffd34dc77191155623fab466481aede34
    Related-bug: #1515273

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-sahara (master)

Reviewed: https://review.openstack.org/245253
Committed: https://git.openstack.org/cgit/openstack/puppet-sahara/commit/?id=ab50eeef0cb33743a14558f56031aafb9842726a
Submitter: Jenkins
Branch: master

commit ab50eeef0cb33743a14558f56031aafb9842726a
Author: Denis Egorenko <email address hidden>
Date: Fri Nov 13 20:13:08 2015 +0300

    Use $::os_service_default where is possible

    This is a second part of switching to $::os_service_default fact.
    Switch to $::os_service_default all params, which are possible
    to use with $::os_service_default fact.

    Related-bug: #1515273

    Change-Id: I54609f09998f29e8dffc12ca4591044dbf67b09b

Nikita Karpin (mkarpin)
Changed in puppet-heat:
status: New → In Progress
Changed in puppet-keystone:
status: In Progress → Fix Released
Changed in puppet-murano:
status: New → Fix Released
Changed in puppet-sahara:
status: New → Fix Released
Changed in puppet-tuskar:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-keystone (master)

Reviewed: https://review.openstack.org/247743
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=4b87767b3bc20f0cfc18109cac0a8d791acce629
Submitter: Jenkins
Branch: master

commit 4b87767b3bc20f0cfc18109cac0a8d791acce629
Author: Iury Gregory Melo Ferreira <email address hidden>
Date: Sat Nov 21 03:24:54 2015 +0000

    $::os_service_default in db and logging

    Switch to $::os_service_default all params in logging and db.
    Changes: logging.pp, db.pp and tests.

    Related-bug: #1515273

    Change-Id: Ib84dceafb032747adc1d8b6e56bd01e89aa802cb

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-ironic (master)

Reviewed: https://review.openstack.org/249274
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=4fbee7da578c7eb88e3642442e553c6ddbfa8fc9
Submitter: Jenkins
Branch: master

commit 4fbee7da578c7eb88e3642442e553c6ddbfa8fc9
Author: Iury Gregory Melo Ferreira <email address hidden>
Date: Tue Nov 24 12:01:54 2015 +0000

    Ironic $::os_service_default for db and logging

    Switch to $::os_service_default all params in logging and db.
    Changes: logging.pp, db.pp and tests.

    Related-bug: #1515273

    Change-Id: Ib0245e8b679010974624faf5dda3e6d6e957cda7

Changed in puppet-ironic:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-ceilometer (master)

Reviewed: https://review.openstack.org/249377
Committed: https://git.openstack.org/cgit/openstack/puppet-ceilometer/commit/?id=6156cb49f29b13321bb719de57e4e4cd08838a3d
Submitter: Jenkins
Branch: master

commit 6156cb49f29b13321bb719de57e4e4cd08838a3d
Author: Iury Gregory Melo Ferreira <email address hidden>
Date: Tue Nov 24 11:20:09 2015 +0000

    Ceilometer $::os_service_default for db and log

    Switch to $::os_service_default all params in logging and db.
    Changes: logging.pp, db.pp and tests.

    Related-bug: #1515273

    Change-Id: I412104bf46c4b40fdbd366e3a8a9dc9de5abb5fd

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-barbican (master)

Reviewed: https://review.openstack.org/249401
Committed: https://git.openstack.org/cgit/openstack/puppet-barbican/commit/?id=e2e560642af96107b93872b0c0072b66c0658dab
Submitter: Jenkins
Branch: master

commit e2e560642af96107b93872b0c0072b66c0658dab
Author: Iury Gregory Melo Ferreira <email address hidden>
Date: Tue Nov 24 20:14:18 2015 +0000

    Barbican $::os_service_default for db and logging

    Switch to $::os_service_default all params in logging and db.
    Changes: logging.pp, db.pp and tests.

    Related-bug: #1515273

    Change-Id: I291db92684e6f31aca2bffa55ed2f3832e905a43

Changed in puppet-manila:
status: In Progress → Fix Released
Changed in puppet-ceilometer:
status: In Progress → Fix Released
Changed in puppet-barbican:
status: In Progress → Fix Released
Changed in puppet-nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-manila (master)

Reviewed: https://review.openstack.org/249394
Committed: https://git.openstack.org/cgit/openstack/puppet-manila/commit/?id=e6ab8881eee1bae28a465f9ab51311eae8674f6e
Submitter: Jenkins
Branch: master

commit e6ab8881eee1bae28a465f9ab51311eae8674f6e
Author: Iury Gregory Melo Ferreira <email address hidden>
Date: Tue Nov 24 19:49:36 2015 +0000

    Manila $::os_service_default for db and log

    Switch to $::os_service_default all params in logging and db.
    Changes: logging.pp, db.pp and tests.

    Related-bug: #1515273

    Change-Id: Idf7bc36d321328391a1b361add965c53627124a4

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-heat (master)

Reviewed: https://review.openstack.org/249119
Committed: https://git.openstack.org/cgit/openstack/puppet-heat/commit/?id=ae2044375198353f262148565d9afc8c703b9cd0
Submitter: Jenkins
Branch: master

commit ae2044375198353f262148565d9afc8c703b9cd0
Author: Mykyta Karpin <email address hidden>
Date: Tue Nov 24 12:37:40 2015 +0200

    Switch Heat to $::os_service_default - part 1

    Switching Heat to usage of os_service_default fact

    Change-Id: Iff9cda880bb938b1fff3bf217c7cbf233daaf68a
    Related-bug: #1515273

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-nova (master)

Reviewed: https://review.openstack.org/248901
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=2a4e110a7e8938f9151bf2e3b2897dbcf10d537c
Submitter: Jenkins
Branch: master

commit 2a4e110a7e8938f9151bf2e3b2897dbcf10d537c
Author: Iury Gregory Melo Ferreira <email address hidden>
Date: Mon Nov 23 20:37:52 2015 +0000

    Switch Nova to $::os_service_default - Part1

    Switch Nova to use $::os_service_default
    Change logging.pp, db.pp and tests.

    Change-Id: I928a93534c6d27c020b7afb5b7dda32c379e9d62
    Related-bug: #1515273

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to puppet-neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/253416

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-aodh (master)

Reviewed: https://review.openstack.org/240222
Committed: https://git.openstack.org/cgit/openstack/puppet-aodh/commit/?id=86d3e7e214a536a88ee4f4c4e26b9e1e36d09ea8
Submitter: Jenkins
Branch: master

commit 86d3e7e214a536a88ee4f4c4e26b9e1e36d09ea8
Author: Gael Chamoulaud <email address hidden>
Date: Thu Oct 29 13:44:43 2015 +0100

    Switch aodh to use os_service_default fact

    This change switches the aodh module to use the os_service_default
    fact for configuration options that default to '<SERVICE DEFAULT>'.

    Related-bug: #1515273
    Change-Id: I05488c8bdcb5f54976a17aa25bf8a3b9d46627bb
    Signed-off-by: Gael Chamoulaud <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-gnocchi (master)

Reviewed: https://review.openstack.org/240034
Committed: https://git.openstack.org/cgit/openstack/puppet-gnocchi/commit/?id=9377bbb813fa9692e8983dabca1155245c43ee0d
Submitter: Jenkins
Branch: master

commit 9377bbb813fa9692e8983dabca1155245c43ee0d
Author: Gael Chamoulaud <email address hidden>
Date: Wed Oct 28 20:45:29 2015 +0100

    Switch gnocchi to use os_service_default fact

    This change switches the gnocchi module to use the os_service_default
    fact for configuration options that default to '<SERVICE DEFAULT>'.

    Related-bug: #1515273
    Change-Id: I88f51a7025905b381c117675afc30a9ec1756c5b
    Signed-off-by: Gael Chamoulaud <email address hidden>

Nikita Karpin (mkarpin)
Changed in puppet-heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to puppet-neutron (master)

Reviewed: https://review.openstack.org/253416
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=5379de00d0dfeb95b5c7cbe603027163b495c873
Submitter: Jenkins
Branch: master

commit 5379de00d0dfeb95b5c7cbe603027163b495c873
Author: Sergey Kolekonov <email address hidden>
Date: Fri Dec 4 13:01:44 2015 +0300

    Move Neutron to $::os_service_default - part 2

    This change updates the values in main classes that are currently set to
    the same values as in default configuration files to $::os_service_default fact

    Change-Id: I5279cfd72192534a5ffcfdaf71b257b082a8b42c
    Related-bug: #1515273

Revision history for this message
Emilien Macchi (emilienm) wrote :
Changed in puppet-aodh:
assignee: Gael Chamoulaud (gael-chamoulaud) → Denis Egorenko (degorenko)
status: New → Fix Released
Changed in puppet-gnocchi:
status: New → Fix Released
Changed in puppet-neutron:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers