Modules *::keystone::auth should always pass auth_name to keystone::resource::service_identity and have a consistent service_name

[Alex Schultz]

All of the puppet classes contain a <class>::keystone::auth class that configure the keystone roles, users and endpoints for the service. These classes should always pass the $auth_name that is different than the service name to keystone::resource::service_identity to allow a user to configure a different username. The service_name should also be set to something consistent to the name of the service and not the username used for keystone.

Currently some classes use the $auth_name as the title for the resource itself. The resource itself should be hardcoded to the name of the service, eg. 'cinder', 'nova', 'neutron' rather than leveraging a dynamic variable. The title of the resource is actually used in the construction of the email for the user and the service description by default (https://github.com/openstack/puppet-keystone/blob/master/manifests/resource/service_identity.pp#L120)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326643

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326645

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326826

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326831

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326833

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326840

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/326847

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/326860

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326860
Committed: https://git.openstack.org/cgit/openstack/puppet-barbican/commit/?id=dadb8de7a85fe3bc7ae0729631a9f3e49de11f8d
Submitter: Jenkins
Branch: master

commit dadb8de7a85fe3bc7ae0729631a9f3e49de11f8d
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Wed Jun 8 09:49:39 2016 +0300

    Change default service_name to 'barbican'

    While we were already able to pick an independent auth_name and
    service_name; the service_name was defaulting to auth_name. Now it
    has a value of its own to be consistent with other modules.

    Related-Bug: #1590040
    Change-Id: Ied45e546667b7c04e9b511a3ae23c529ad78e7df

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/327117

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/327152

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/327190

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326645
Committed: https://git.openstack.org/cgit/openstack/puppet-ceilometer/commit/?id=8363e51b3ca8721bb092932728ba3833bfb42a7f
Submitter: Jenkins
Branch: master

commit 8363e51b3ca8721bb092932728ba3833bfb42a7f
Author: Alex Schultz <email address hidden>
Date: Tue Jun 7 10:52:42 2016 -0600

    Provide default service_name for keystone endpoint

    This change updates the ceilometer::keystone::auth class to include a
    default service_name of 'ceilometer' so that if a user changes the
    auth_name, the service is still created as being related to
    'ceilometer'. This improves the user experiance when they want to
    customize the usernames for services.

    Change-Id: I472dd78c1b4fd8d3d4667aede56358cf6254617d
    Closes-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326831
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=96ec7b5becda9ebcfb38a4bc6405ba183bfc95b1
Submitter: Jenkins
Branch: master

commit 96ec7b5becda9ebcfb38a4bc6405ba183bfc95b1
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Wed Jun 8 08:38:07 2016 +0300

    Provide default service_name for keystone endpoint

    This change updates the nova::keystone::auth class to include a
    default service_name of 'nova' so that if a user changes the
    auth_name, the service is still created as being related to 'nova'.

    Change-Id: Iaf616a094bd2192fe0149307065cec11038d8c85
    Closes-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/327193

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/327252

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326847
Committed: https://git.openstack.org/cgit/openstack/puppet-octavia/commit/?id=e8e6a527f3995c8f179fa0c91681763d1569453b
Submitter: Jenkins
Branch: master

commit e8e6a527f3995c8f179fa0c91681763d1569453b
Author: ZhongShengping <[e-mail]>
Date: Wed Jun 8 14:22:13 2016 +0800

    Provide default service_name for keystone endpoint

    This change updates the octavia::keystone::auth class to include a
    default service_name of 'octavia' so that if a user changes the
    auth_name, the service is still created as being related to 'octavia'.
    This improves the user experiance when they want to customize the
    usernames for services.

    Change-Id: I2241cc2ea581c4ef6726aee8be2026eba4fd02f8
    Closes-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Change abandoned by Marcellin Fom Tchassem (<email address hidden>) on branch: master
Review: https://review.openstack.org/327190

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326840
Committed: https://git.openstack.org/cgit/openstack/puppet-sahara/commit/?id=d9cd695e692e52efd6698d4b1e2364dc3eaca017
Submitter: Jenkins
Branch: master

commit d9cd695e692e52efd6698d4b1e2364dc3eaca017
Author: ZhongShengping <[e-mail]>
Date: Wed Jun 8 14:10:25 2016 +0800

    Provide default service_name for keystone endpoint

    This change updates the sahara::keystone::auth class to include a default
    service_name of 'sahara' so that if a user changes the auth_name, the
    service is still created as being related to 'sahara'. This improves the
    user experiance when they want to customize the usernames for services.

    Change-Id: I8c6240473213b107de862edf359834b5494e9f74
    Closes-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326833
Committed: https://git.openstack.org/cgit/openstack/puppet-zaqar/commit/?id=c2acaba000ca22d28f6807942f9a5fed3cb6fb90
Submitter: Jenkins
Branch: master

commit c2acaba000ca22d28f6807942f9a5fed3cb6fb90
Author: ZhongShengping <[e-mail]>
Date: Wed Jun 8 13:52:19 2016 +0800

    Provide default service_name for keystone endpoint

    This change updates the zaqar::keystone::auth class to include a default
    service_name of 'zaqar' so that if a user changes the auth_name, the
    service is still created as being related to 'zaqar'. This improves the
    user experiance when they want to customize the usernames for services.

    Change-Id: I2977790c3558732c2a1773aa3ede834c1d62ca16
    Closes-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326836
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=cd863e67c1e64bc3cc89e4b08b7575797b091f49
Submitter: Jenkins
Branch: master

commit cd863e67c1e64bc3cc89e4b08b7575797b091f49
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Wed Jun 8 09:01:08 2016 +0300

    Provide default service_name for keystone endpoint

    This change updates the neutron::keystone::auth class to include a
    default service_name of 'neutron' so that if a user changes the
    auth_name, the service is still created as being related to
    'neutron'.

    Closes-bug: #1590040
    Change-Id: I3b23ad48a2b080ee32b333b81dcfe7f2369ee2e4

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326826
Committed: https://git.openstack.org/cgit/openstack/puppet-glance/commit/?id=f2855769b3352fc5f7c9f509ea60f1b0bc379a4e
Submitter: Jenkins
Branch: master

commit f2855769b3352fc5f7c9f509ea60f1b0bc379a4e
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Wed Jun 8 07:57:35 2016 +0300

    Provide consisent default name for service_identity resource

    This change updates glance::keystone::auth to include the
    user-provided auth_name as a parameter for the service_identity
    provider. Hardcoding the namevar of that resource as was agreed. the
    service_name parameter was not undef as in other resources, so the
    name was left as-is. And we no longer pick a service_name out of the
    service_name and auth_name; now only the service_name is taken into
    account.

    Closes-Bug: #1590040
    Change-Id: I757930e05b6e14cb15139840c9e4a513c9af5d17

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326643
Committed: https://git.openstack.org/cgit/openstack/puppet-aodh/commit/?id=ca6b879872dcb185e3c0dccbcc76a55b9af6d6df
Submitter: Jenkins
Branch: master

commit ca6b879872dcb185e3c0dccbcc76a55b9af6d6df
Author: Alex Schultz <email address hidden>
Date: Tue Jun 7 10:51:01 2016 -0600

    Provide default service_name for keystone endpoint

    This change updates the aodh::keystone::auth class to include a default
    service_name of 'aodh' so that if a user changes the auth_name, the
    service is still created as being related to 'aodh'. This improves the
    user experiance when they want to customize the usernames for services.

    Change-Id: I9de75cbe7947282739e13e2f397ee7e919f7dc9f
    Closes-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/327193
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=b2a1ce63f33b8ae46aeaf5b0d1a1446025355aec
Submitter: Jenkins
Branch: master

commit b2a1ce63f33b8ae46aeaf5b0d1a1446025355aec
Author: Marcellin Fom Tchassem <email address hidden>
Date: Tue Jun 7 19:35:28 2016 -0500

    Change default service_name to 'cinder'

    While we were already able to pick an independent auth_name and
    service_name; the service_name was defaulting to auth_name. Now it
    has a value of its own to be consistent with other modules.

    Change-Id: I76bd088d48f702ecb1f57818475e759bce1a6bb0
    Related-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/327152
Committed: https://git.openstack.org/cgit/openstack/puppet-trove/commit/?id=e99cc9e7cecc199af7bda0cd9d36a091938d3763
Submitter: Jenkins
Branch: master

commit e99cc9e7cecc199af7bda0cd9d36a091938d3763
Author: Marcellin Fom Tchassem <email address hidden>
Date: Tue Jun 7 18:35:04 2016 -0500

    Change default service_name to 'trove'

    While we were already able to pick an independent auth_name and
    service_name; the service_name was defaulting to auth_name. Now it
    has a value of its own to be consistent with other modules.

    Change-Id: If3f29c1f4efe2eeb5ff9173628403dfcc7f48e57
    Related-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/327117
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=f21260370ff6f28b8d5034b239458f1eb0c98daa
Submitter: Jenkins
Branch: master

commit f21260370ff6f28b8d5034b239458f1eb0c98daa
Author: Marcellin Fom Tchassem <email address hidden>
Date: Tue Jun 7 18:06:50 2016 -0500

    Change default service_name to 'ironic'

    While we were already able to pick an independent auth_name and
    service_name; the service_name was defaulting to auth_name. Now it
    has a value of its own to be consistent with other modules.

    Change-Id: I6fee7965ec51928df9a81cacbcf60aebadb7becf
    Related-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/324749
Committed: https://git.openstack.org/cgit/openstack/puppet-murano/commit/?id=65ece2453b24cfaebea77c436c448fd426fffada
Submitter: Jenkins
Branch: master

commit 65ece2453b24cfaebea77c436c448fd426fffada
Author: Venkata Mahesh Jonnalagadda <email address hidden>
Date: Thu Jun 2 14:16:23 2016 -0400

    Provide default service_name for keystone endpoint

    This change updates the murano::keystone::auth class to include a default
    service_name of 'murano' so that if a user changes the auth_name, the
    service is still created as being related to 'murano'. This improves the
    user experiance when they want to customize the usernames for services.

    Closes-bug: #1590040
    Change-Id: I031103fe611d176dcbddf665bd2e66e230610c91

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/324764
Committed: https://git.openstack.org/cgit/openstack/puppet-heat/commit/?id=6f16641c4e35e12844bd4b5c9a4bbf9c8d030886
Submitter: Jenkins
Branch: master

commit 6f16641c4e35e12844bd4b5c9a4bbf9c8d030886
Author: Venkata Mahesh Jonnalagadda <email address hidden>
Date: Thu Jun 2 14:50:52 2016 -0400

    Provide default service_name for keystone endpoint

    This change updates the heat::keystone::auth class to include a default
    service_name of 'heat' so that if a user changes the auth_name, the
    service is still created as being related to 'heat'. This improves the
    user experiance when they want to customize the usernames for services.

    Closes-Bug: #1590040

    Change-Id: Iee47e78dbeb269e5fe6c52030de378c13e51c1f3

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/328667

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/328710

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/326031
Committed: https://git.openstack.org/cgit/openstack/puppet-designate/commit/?id=d645b1ed880bef8d9bbe9837148e9345bb85682a
Submitter: Jenkins
Branch: master

commit d645b1ed880bef8d9bbe9837148e9345bb85682a
Author: Venkata Mahesh Jonnalagadda <email address hidden>
Date: Mon Jun 6 12:34:56 2016 -0400

    Provide default service_name for keystone endpoint

    This change updates the designate::keystone::auth class to include a default
    service_name of 'designate' so that if a user changes the auth_name, the
    service is still created as being related to 'designate'. This improves the
    user experiance when they want to customize the usernames for services.

    Closes-bug: #1590040

    Change-Id: I58658de33ba90d2f8d6fbc1aaa0099f1ad024aa6

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/324356
Committed: https://git.openstack.org/cgit/openstack/puppet-mistral/commit/?id=87c7e5d22f3628fc2e9fdbd0cecd5ca2b2ea07c5
Submitter: Jenkins
Branch: master

commit 87c7e5d22f3628fc2e9fdbd0cecd5ca2b2ea07c5
Author: Venkata Mahesh Jonnalagadda <email address hidden>
Date: Thu Jun 2 06:32:50 2016 -0400

    Provide default service_name for keystone endpoint

    This change updates the mistral::keystone::auth class to include a default
    service_name of 'mistral' so that if a user changes the auth_name, the
    service is still created as being related to 'mistral'. This improves the
    user experiance when they want to customize the usernames for services.

    Closes-bug: #1590040

    Change-Id: I94d5429a21acea5d9fe8812f85fb65cfeb3094a3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/328667
Committed: https://git.openstack.org/cgit/openstack/puppet-manila/commit/?id=4b9b42d80025e1fd60253929a224c294e094f062
Submitter: Jenkins
Branch: master

commit 4b9b42d80025e1fd60253929a224c294e094f062
Author: ZhongShengping <[e-mail]>
Date: Sun Jun 12 10:00:35 2016 +0800

    Provide default service_name for keystone endpoint

    This change updates the manila::keystone::auth class to include a default
    service_name of 'manila' so that if a user changes the auth_name, the
    service is still created as being related to 'manila'. This improves the
    user experiance when they want to customize the usernames for services.

    Change-Id: I8c6240473213b107de862edf359834b5494e9f74
    Closes-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/327252
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=ce3bd6fd8fee5a534319f578f359d82bb2f1598b
Submitter: Jenkins
Branch: master

commit ce3bd6fd8fee5a534319f578f359d82bb2f1598b
Author: Marcellin Fom Tchassem <email address hidden>
Date: Tue Jun 7 20:54:47 2016 -0500

    Change default service_name to 'swift'

    While we were already able to pick an independent auth_name and
    service_name; the service_name was defaulting to auth_name. Now it
    has a value of its own to be consistent with other modules.

    Change-Id: I24e091d509775a11b42298185db71ca00b94b4fe
    Related-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/328710
Committed: https://git.openstack.org/cgit/openstack/puppet-gnocchi/commit/?id=857ba17d39a5714552c8b2a9e63851022a02754e
Submitter: Jenkins
Branch: master

commit 857ba17d39a5714552c8b2a9e63851022a02754e
Author: ZhongShengping <[e-mail]>
Date: Sun Jun 12 16:37:27 2016 +0800

    Provide default service_name for keystone endpoint

    This change updates the gnocchi::keystone::auth class to include a default
    service_name of 'gnocchi' so that if a user changes the auth_name, the
    service is still created as being related to 'gnocchi'. This improves the
    user experiance when they want to customize the usernames for services.

    Additional changes:

    * update related spec test
    * add a release note
    * add the service_description option in order to configure it

    Change-Id: Iaca2fe1ec33041593ddc8ee9b7bd7a0cd31f1f3f
    Closes-Bug: #1590040

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-aodh 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-ceilometer 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-designate 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-glance 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-gnocchi 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-heat 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-manila 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-mistral 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-murano 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-neutron 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-nova 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-sahara 9.1.0 release.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-zaqar 9.1.0 release.

[Alex Schultz (alex-schultz)]

released in 9.2.0 of puppet-trove

[Alex Schultz (alex-schultz)]

fix released in 9.2.0 of puppet-ironic

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/380806

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/380811

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/380811
Committed: https://git.openstack.org/cgit/openstack/puppet-monasca/commit/?id=d8859186cd2552da95d21fecc76a743d08a2ff8c
Submitter: Jenkins
Branch: master

commit d8859186cd2552da95d21fecc76a743d08a2ff8c
Author: Sharat Sharma <email address hidden>
Date: Sun Oct 2 12:29:51 2016 +0530

    Provide default service_name for keystone endpoint

    This change updates the monasca::keystone::auth class to include a
    default service_name of 'monasca' so that if a user changes the
    auth_name, the service is still created as being related to
    'monasca'.

    Change-Id: Id973e70d27072c0478aae68f288ee5d638037b36
    Closes-Bug: #1590040

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sharat Sharma (<email address hidden>) on branch: master
Review: https://review.openstack.org/380806