Request: more graph details & manually set baselines?

[Si Dedman]

Hi, love the program, very small request: would it be possible to add more detail to the graphs e.g. temps on major lines, and especially add fan RPM on right hand side? If we could set the graduations/min/max manually like in Excel that would be great.

(I don't know if i'll need this because i'm looking into a problem where my IDE sensor is reading ~10X higher than my SATAs, and I need to look into fan stuff also, but:) Also, would it be possible to be able to manually set baselines and have psensor graph relative to those? E.g. then I won't need to find the cause of my IDE sensor problem, I can just workaround.

Thanks

Si

[Si Dedman (si-dedman)]

Forgot to include another graphing request: smoothing option: would be nice to be able to add a smoothing function to the lines, auto & manually set, so you'd get a smooth line rather than it jumping back & forth between 1deg increments. I suppose another option would be not to round to degrees but display as decimals, which would smooth it naturally.

[Jean-Philippe Orsini (jfi)]

I agree that it should be nice, and similar ideas has already been requested.

That's not a bug but a feature request, so I mark it as a wish.

[Francis Chin (chinf)]

The current mechanism for smoothing (added in 2014) makes clever use of Bezier curves but has limitations: the sub-sampling of data results in aliasing which has to be mitigated by starting every plot at a multiple of 3 samples (or else the curve looks significantly different); it does not smooth 1 in 3 samples at all (so in many cases you still get sharp 1 degree "teeth" due to the integer value resolution from the data sources); some transitions are sharp because control points don't adhere to the same tangent at each point.

So - I had a go at a new plotting routine which renders the data with curves, and added in a configurable smoothing function based on an IIR filter. Along the way I used a second Cairo surface to clip the graph lines, so the full graph area can now be transparent as the left and sides don't need to cover up overdraw. I made the y-axis show temperature, speed and usage scales automatically depending upon the sensors selected for graphing. I changed the y-axis default to show on the right hand side nearest the latest value (with a pref to select the left hand side if preferred). I added in a feature to tag the ends of the curves with a label of the current value and sensor name. The preferences I added take effect immediately.

I tweaked the glade file for the main UI so that I no longer get Gtk_WARNING and Gtk-CRITICAL errors when sensors tree is given too little vertical space when resizing or changing the layout from right/left to top/bottom.

I noticed that running 1.2.0 (excluding my patches) seems to leak a little memory (up to around 50MiB instead of the ~10MiB it starts with) when run for several days. I ran valgrind to try and see whether I could fix anything; I believe I've put in the right free()s in my patch and in my limited testing it hasn't gone above ~25MiB, but could always do with more testing.

[Francis Chin (chinf)]

I was confused by the old Preferences dialog referring to a "Foreground" colour for the graph thinking that this referred to the axis labels; in fact this only applied to the gridlines. I think this preference should apply to both components as using the theme foreground colour for the labels is inappropriate if transparency is used; having the pref control both allows a contrasting colour to be set by the user. I have updated the patch to enable this and clarify the wording on the preferences dialog.

[Jean-Philippe Orsini (jfi)]

Great work! I will have a look at this one as soon as possible.