iLO reports "Inserted": true in VirtualMedia object even if image URL is not valid

[Jacob Anders]

Description of problem:

When configuring virtual media via RedFish on HP e910 server, if the URL specified isn't valid or reachable, the BMC still reports "Inserted": true. It seems it always reports "Inserted": true if there is any URL set.

Version:

Various, I recently reproduced this on latest (as per 25 January 2022) BIOS 1.90 and latest iLO 2.55.

How reproducible:

Steps to Reproduce:
1. Attach a vMedia image using an incorrect URL, e.g.

$ curl -X POST https://HOST/redfish/v1/Managers/1/VirtualMedia/2/Actions/VirtualMedia.InsertMedia --user USER:PASS --insecure -d '{"Image": "https://11.22.33.44/iso/file.iso"}' -H "Content-Type: application/json" | jq
{
  "error": {
    "code": "iLO.0.10.ExtendedInfo",
    "message": "See @Message.ExtendedInfo for more information.",
    "@Message.ExtendedInfo": [
      {
        "MessageId": "Base.1.4.Success"
      }
    ]
  }
}

2.Check configuration

$ curl -ksu USER:PASS https://HOST/redfish/v1/Managers/1/VirtualMedia/2 | jq
{
  "@odata.context": "/redfish/v1/$metadata#VirtualMedia.VirtualMedia",
  "@odata.etag": "W/\"3E4155BE\"",
  "@odata.id": "/redfish/v1/Managers/1/VirtualMedia/2",
  "@odata.type": "#VirtualMedia.v1_2_0.VirtualMedia",
  "Id": "2",
  "Actions": {
    "#VirtualMedia.EjectMedia": {
      "target": "/redfish/v1/Managers/1/VirtualMedia/2/Actions/VirtualMedia.EjectMedia"
    },
    "#VirtualMedia.InsertMedia": {
      "target": "/redfish/v1/Managers/1/VirtualMedia/2/Actions/VirtualMedia.InsertMedia"
    }
  },
  "ConnectedVia": "URI",
  "Description": "Virtual Removable Media",
  "Image": "https://11.22.33.44/iso/file.iso",
  "ImageName": "file.iso",
  "Inserted": true,
  "MediaTypes": [
    "CD",
    "DVD"
  ],
  "Name": "VirtualMedia",
  "Oem": {
    "Hpe": {
      "@odata.context": "/redfish/v1/$metadata#HpeiLOVirtualMedia.HpeiLOVirtualMedia",
      "@odata.type": "#HpeiLOVirtualMedia.v2_2_0.HpeiLOVirtualMedia",
      "Actions": {
        "#HpeiLOVirtualMedia.EjectVirtualMedia": {
          "target": "/redfish/v1/Managers/1/VirtualMedia/2/Actions/Oem/Hpe/HpeiLOVirtualMedia.EjectVirtualMedia"
        },
        "#HpeiLOVirtualMedia.InsertVirtualMedia": {
          "target": "/redfish/v1/Managers/1/VirtualMedia/2/Actions/Oem/Hpe/HpeiLOVirtualMedia.InsertVirtualMedia"
        }
      },
      "BootOnNextServerReset": false
    }
  },
  "WriteProtected": true
}

Actual results:

Property "Inserted": true is set despite this URL not being reachable from the BMC.

Expected results:

The BMC should reject the URL as it is not reachable and/or valid.

Additional info:

When the wrong URL is specified, the vMedia device is not visible in the OS. It only appears when a valid image is specified. I think "Inserted": true should be in line with what is visible in the OS.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/x/proliantutils/+/828817

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/x/proliantutils/+/828817
Committed: https://opendev.org/x/proliantutils/commit/792cd4185bfad79b4b3f8482f52faa74503f8acf
Submitter: "Zuul (22348)"
Branch: master

commit 792cd4185bfad79b4b3f8482f52faa74503f8acf
Author: paresh-sao <email address hidden>
Date: Thu Feb 10 11:10:36 2022 +0000

    Fix virtual media insertion of invalid url

    This patch fixes 'insert_virutal_media' api to through an error
    when the url given is either invalid or unreachable.

    Closes-Bug: 1958976
    Change-Id: I1d49086e214fe86a5bf5bc3986e7e886ee28ff30

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/x/proliantutils/+/829863

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/x/proliantutils/+/829863
Committed: https://opendev.org/x/proliantutils/commit/77989f59ab394510bdfaae9cbae96054027f437e
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 77989f59ab394510bdfaae9cbae96054027f437e
Author: paresh-sao <email address hidden>
Date: Thu Feb 10 11:10:36 2022 +0000

    Fix virtual media insertion of invalid url

    This patch fixes 'insert_virutal_media' api to through an error
    when the url given is either invalid or unreachable.

    Closes-Bug: 1958976
    Change-Id: I1d49086e214fe86a5bf5bc3986e7e886ee28ff30
    (cherry picked from commit 792cd4185bfad79b4b3f8482f52faa74503f8acf)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/x/proliantutils/+/829880

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/x/proliantutils/+/829880
Committed: https://opendev.org/x/proliantutils/commit/14296453c579a85f1b759a74004ce4507cab9256
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 14296453c579a85f1b759a74004ce4507cab9256
Author: paresh-sao <email address hidden>
Date: Thu Feb 10 11:10:36 2022 +0000

    Fix virtual media insertion of invalid url

    This patch fixes 'insert_virutal_media' api to through an error
    when the url given is either invalid or unreachable.

    Closes-Bug: 1958976
    Change-Id: I1d49086e214fe86a5bf5bc3986e7e886ee28ff30
    (cherry picked from commit 792cd4185bfad79b4b3f8482f52faa74503f8acf)