Test fails when there is internet connectivity

[Thomas Goirand]

Hi !

proliantutils.tests.ilo.test_firmware_controller.FirmwareImageUploaderTestCase.test__get_socket_throws_exception_in_case_of_failed_connection_2 fails when there's internet connectivity. Instead of 1.1.1.1, we should use something like 198.51.100.1, which is a reserved /24 for documentation, and which therefore will always really raise a connection error. This was reported in Debian:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902241

and I wrote a patch for it, as per what's above, and that fixed the issue.

[Thomas Goirand (thomas-goirand)]

Hum... looks like 1.1.1.1 was already removed from the test suite. Should we re-introduce 198.51.100.1 in the test decoration?

[Shivanand Tendulker (stendulker)]

This has been fixed as part of https://review.openstack.org/#/c/559685/ on master branch.