Group search by title returns all groups

Bug #656011 reported by Ross Patterson on 2010-10-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Products.LDAPMultiPlugins
Medium
Unassigned

Bug Description

When searching for groups using PAS enumerateGroups with a "title" kwarg, all groups are returned. In Products.LDAPMultiPlugins-1.12-py2.6.egg/Products/LDAPMultiPlugins/ActiveDirectoryMultiPlugin.py(385)enumerateGroups() it seems like the kwargs are ignored, only used for the cache key and nothing else.

Changed in products.ldapmultiplugins:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Jens Vagelpohl (dataflake)
Ross Patterson (rossp) wrote :

The attached patch fixes the problem on my client's deployment. It's a pretty dumb patch, I just copied the code from LDAPUserFolder that assembles the LDAP delegate query string from kwargs and pasted it into the ActiveDirectoryMultiPlugin.enumerateGroups method. I note that the LDAPMultiPlugin.enumerateGroups() actually calls acl.searchGroups and I was unable to figure out if there was a reason that ActiveDirectoryMultiPlugin.enumerateGroups() does not. I also didn't add test coverage for this or run the tests. Sorry, I'm just not familiar enough with this stack.

Changed in products.ldapmultiplugins:
status: Confirmed → In Progress

Thanks for the patch, I incorporated it:

http://svn.dataflake.org/viewvc?view=revision&revision=2044

I'll release version 1.13 today as well.

Changed in products.ldapmultiplugins:
status: In Progress → Fix Committed
Changed in products.ldapmultiplugins:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers