Twitter sync weirdness

[Brad Phillips]

During sync of my contacts, Gmail went through fine. The Twitter sync, reported a ton of errors on aiki php files (though it said the import was successful). After a few page refreshes, I did eventually see the updated contacts list, but there may be an issue in some of the twitter php code that's causing some hiccup.

A screenshot of the errors is provided below.

[rejon (rejon)]

do you have listing of those errors and/or can you reset with chris'
kill switch and take a screenshot and attach please...thx

On Wed, Jan 26, 2011 at 7:44 PM, Brad Phillips
<email address hidden> wrote:
> Public bug reported:
>
> During sync of my contacts, Gmail went through fine.  The Twitter sync,
> reported a ton of errors on aiki php files (though it said the import
> was successful).  After a few page refreshes, I did eventually see the
> updated contacts list, but there may be an issue in some of the twitter
> php code that's causing some hiccup.
>
> A screenshot of the errors is provided below.
>
> ** Affects: ppl
>     Importance: Undecided
>         Status: New
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/708217
>
> Title:
>  Twitter sync weirdness
>

--
Jon Phillips
http://rejon.org/
http://fabricatorz.com/
chat/skype: kidproto | irc: rejon
+1.415.830.3884 (sf/global)
[phone] (berlin)
+86.187.1003.9974 (china)
+852.9647,9389 (hongkong)
+65.8330.5807 (singapore)

[Christopher Adams (christopheradams)]

This error originates in the twitteroauth library, which is an extension external to the PPL code proper.

Our ppl_twitter.php checks that this session variable is set:

  isset($_REQUEST['oauth_verifier'])

If that were not set, then the code would output an error: There is no valid session for this request.

In Brad's case this variable must have been set. The ppl_twitter code then creates a new TwitterOAuth object and passes that session variable:

  $access_token = $connection->getAccessToken($_REQUEST['oauth_verifier']);

There needs to be more error checking either in the PPL code or in the TwitterOAuth code.

Brad, are you able to reliably reproduce this error? In the absence of that I can't make it a priority to dig into the TwitterOAuth code to fix this.