Duplicated test URLs and no all-proposed URLs

[Athos Ribeiro]

When passing the -L option to the tests command to get the actual URLs in the tool output (instead of the pretty UTF-8 icons), We get duplicated URLs instead of the ones with "all-proposed=1".

[Bryce Harrington (bryce)]

Thanks for filing this. It appears to occur for the regular usage:

$ ./scripts/ppa tests -L ppa:seb128/update-manager-sru -a amd64 -p distro-info
* Triggers:
  - Source distro-info/0.14ubuntu0.3: Published
    + @amd64: https://autopkgtest.ubuntu.com/request.cgi?release=xenial&package=distro-info&arch=amd64&trigger=distro-info%2F0.14ubuntu0.3&ppa=seb128%2Fupdate-manager-sru♻️
* Results:
  ...

But the all-proposed links do show up with --show-rdepends:

$ ./scripts/ppa tests --show-rdepends -L ppa:seb128/update-manager-sru -a amd64 -p distro-info
* Triggers:
  - Source distro-info/0.14ubuntu0.3: Published
    + distro-info@amd64: https://autopkgtest.ubuntu.com/request.cgi?release=xenial&package=distro-info&arch=amd64&trigger=distro-info%2F0.14ubuntu0.3&ppa=seb128%2Fupdate-manager-sru♻️
    ...
    + distro-info@amd64: https://autopkgtest.ubuntu.com/request.cgi?release=xenial&package=distro-info&arch=amd64&trigger=distro-info%2F0.14ubuntu0.3&ppa=seb128%2Fupdate-manager-sru💍

[Bryce Harrington (bryce)]

--- a/scripts/ppa
+++ b/scripts/ppa
@@ -1028,7 +1028,8 @@ def command_tests(lp: Lp, config: dict[str, str]) -> int:
                     title = ''
                     if config.get('show_rdepends'):
                         title = trigger.test_package
- print(f" + {trigger.package}@{trigger.arch}: {trigger.action_url}💍")
+ url = trigger.action_url + "&all-proposed=1"
+ print(f" + {trigger.package}@{trigger.arch}: {url}💍")

             else:
                 for trigger in triggers:

Something like this should fix the issue.

[Bryce Harrington (bryce)]

I've implemented this fix in this MP:

    https://code.launchpad.net/~bryce/ppa-dev-tools/+git/ppa-dev-tools-1/+merge/463178

Your review would be appreciated; I'll land the MP once it's approved.