--show-urls does not present urls for result logs

[Brian Murray]

[ 2:39PM 10113 ] [ bdmurray@impulse:~/source-trees/ppa-dev-tools(main✗) ]
 $ scripts/ppa tests --show-urls -a armhf -r kinetic ppa:brian-murray/autopkgtest
* Triggers:
  - Source autopkgtest/5.25ubuntu1.1: Published
    + armhf: https://autopkgtest.ubuntu.com/request.cgi?release=kinetic&package=autopkgtest&arch=armhf&trigger=autopkgtest%2F5.25ubuntu1.1&ppa=brian-murray%2Fautopkgtest♻️
    + armhf: https://autopkgtest.ubuntu.com/request.cgi?release=kinetic&package=autopkgtest&arch=armhf&trigger=autopkgtest%2F5.25ubuntu1.1&ppa=brian-murray%2Fautopkgtest💍

* Results:
  - autopkgtest/5.25ubuntu1.1
    + ✅ autopkgtest on kinetic for armhf @ 25.01.23 16:29:20
    + ✅ autopkgtest on kinetic for armhf @ 25.01.23 16:34:51

* Running: (none)
* Waiting: (none)

[ 2:39PM 10118 ] [ bdmurray@impulse:~/source-trees/ppa-dev-tools(main✗) ]
 $ git rev-parse HEAD
321446afc19cda9b835c1e2514605a97eb42e6f2

The urls are not presented regardless of whether or not I'm using screen.

[Bryce Harrington (bryce)]

Confirmed reproducing this.

This is interesting in that I assumed people wouldn't be as interested in looking at passing tests, so I explicitly omitted the log urls to avoid clutter. However, --show-urls is a pretty good sign that the user does indeed want urls shown... can't argue that point!

Furthermore, when not using --show-urls, the clickable ansi hyperlink is constructed for the line, so the user does have access to the log that way even if the url is not explicitly shown. Since there wasn't access with --show-urls, that's rather inconsistent.

Anyway, with the fix the output looks like:

$ ./scripts/ppa tests --show-urls -a armhf -r kinetic ppa:brian-murray/autopkgtest
* Triggers:
  - Source autopkgtest/5.25ubuntu1.1: Published
    + armhf: https://autopkgtest.ubuntu.com/request.cgi?release=kinetic&package=autopkgtest&arch=armhf&trigger=autopkgtest%2F5.25ubuntu1.1&ppa=brian-murray%2Fautopkgtest♻️
    + armhf: https://autopkgtest.ubuntu.com/request.cgi?release=kinetic&package=autopkgtest&arch=armhf&trigger=autopkgtest%2F5.25ubuntu1.1&ppa=brian-murray%2Fautopkgtest💍

* Results:
  - autopkgtest/5.25ubuntu1.1
    + ✅ autopkgtest on kinetic for armhf @ 25.01.23 16:29:20
      • Log: https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-brian-murray-autopkgtest/kinetic/armhf/a/autopkgtest/20230125_162920_177cc@/log.gz
    + ✅ autopkgtest on kinetic for armhf @ 25.01.23 16:34:51
      • Log: https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic-brian-murray-autopkgtest/kinetic/armhf/a/autopkgtest/20230125_163451_9a05a@/log.gz

* Running: (none)
* Waiting: (none)

MP will be up with this fix shortly.

[Bryce Harrington (bryce)]

This fix is included in the 0.4.0 release.