Power EMail Server Action condition doesn't seems to work

Bug #587801 reported by yohan pannet
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Power Email
Fix Committed
Medium
Sharoon Thomas http://openlabs.co.in

Bug Description

The Server Action created, when you specify 'Auto Email' in the mail template, is of type 'Power Email'.
It seems to me that when you add a condition, it is not evaluated, while this work for other types of actions:

Let's take a mail template related to a point of sale. It uses partner related data (i.e partner email). But partner is not required. Hence the need of a condition on the server action (object.partner_id). When i try to validate a pos with no partner, i got an error.
If i create a 'Multi Actions' server action with the same condition and the mail action in its list, then it works: when i validate a pos with no partner, the condition is evaluated and the action is not executed.

Power E-mail version: 5.0.0.7 RC (revno 197)

Related branches

Revision history for this message
Sharoon Thomas http://openlabs.co.in (sharoonthomas) wrote :

Hello,

Thanks for reporting the issue.
Can you update to the latest code just committed and check?

Thanks

Changed in poweremail:
assignee: nobody → Sharoon Thomas http://openlabs.co.in (sharoonthomas)
importance: Undecided → Medium
milestone: none → 0.7
status: New → Fix Committed
Revision history for this message
yohan pannet (yohan-pannet) wrote :

Done: there is a bug just before evaluation:
end of error:
  File "/home/yohan/dev/servers/openerp-v5/openerp-server-5.0.10/bin/workflow/wkf_expr.py", line 64, in execute_action
    result = obj.run(cr, ident[0], [activity['action_id']], ctx)
  File "/home/yohan/dev/servers/openerp-v5/openerp-server-5.0.10/bin/addons/poweremail/poweremail_serveraction.py", line 78, in run
    'time':time,
NameError: global name 'time' is not defined

Don't know what type of time you expected, so i can't patch a fix

Revision history for this message
Sharoon Thomas http://openlabs.co.in (sharoonthomas) wrote :

My Bad,

I have just fixed this.

Thanks,

Revision history for this message
yohan pannet (yohan-pannet) wrote :

Ok, it works.
Thanks

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.