Click name in message to add or edit contact

[Cris Dywan]

The user sees a name in a message, used as From, To or Copy. Thinking either of

a) There name isn't in the addressbook yet.
b) The name is misspelt, or otherwise wrong.

So the user clicks a small icon next to the name, and Dexter's contact editor shows up, prefilled with either of

a) The email address. And if available, the name - what if the order is Finnish or Asian?
b) The existing contact details. Focus on the first name.

[Cris Dywan (kalikiana)]

Dexter should provide a DBus method "add or edit contact, with email address and name (may be empty)". To make behaviour consistent with any client of Dexter, the method should return immediately while keeping the contact editor open. If invoked a second time, it should focus the existing contact editor. This I think would be most predictable for the user and match behaviour inside Dexter.

In Postler, a small icon is shown next to all names. A click calls the above DBus method. Afterwards, the name is updated if it changed.

[Sergio Spinatelli (spinatelli)]

Would also be interesting to make typing an email address/name into the "To" field search in dexter for contacts and show a popup-list with them (much like google's instant search,but with dexter contacts..)..=)

[Allen Lowe (lallenlowe)]

iTuxer, it already does that! :P

[Sergio Spinatelli (spinatelli)]

really?didn't know that!I didn't actualy try it out..xD
Well,that's awesome news for me! =D

[Cris Dywan (kalikiana)]

Allen, it is looking pretty good but the name matching is a bit off in one case:

"", "<email address hidden>"

If I pass no name and a new address, it matches one of my contacts that doesn't have this address. If I make it "Foo", "<email address hidden>" it works.

[Cris Dywan (kalikiana)]

Alright, so the "" problem is solved.

The feature in Postler is partially done, it doesn't show an icon but only text, I need to find out why that doesn't work.

Remaining issue in Dexter: if I keep the contact dialogue open and forget to close it and then go back to Postler, and it tries to call EditContact again, nothing happens. The callback is apparently blocked by dialog.run ().

I think instead of run() it needs to set a variable and manually make the dialogue modal, and present it otherwise, so DBus callbacks aren't blocked. I'll express the idea in pythonish code:

dialog = None
if dialog == None:
    dialog = gtk.Dialog ()
    # bla
    dialog.set_modal (true)
    dialog.connect ("destroy", dialog_destroyed)
    dialog.show ()
else:
    dialog.present ()

def dialog_destroyed:
    dialog = None

[Cris Dywan (kalikiana)]

For the record, the icon in Postler is working, but after some discussion I am evalutating an action menu instead of an icon.

[Allen Lowe (lallenlowe)]

Christian, what is the status of this currently? Can I mark this as Fixed in Dexter? I believe I solved all the problems...

[Danielle Foré (danrabbit)]

implemented a "add contact" button instead.