Drag files into composer to attach

[Cris Dywan]

Dragging files into the composer, specifically the web view and the attachment area, should attach them.

[Sergio Spinatelli (spinatelli)]

Maybe adding something like

        Gtk.drag_dest_set ( this, Gtk.DestDefaults.ALL, null, Gdk.DragAction.COPY );
     Gtk.drag_dest_add_uri_targets (this);

     this.drag_data_received.connect (on_drag_drop);

and then the function handling

private void on_drag_drop (Gdk.DragContext context, int x, int y, Gtk.SelectionData data, uint info, uint time_){
        string[] uris= data.get_uris();
                //stuff..
               //...
}

should do the job (some string manipulation on the uris and some checks to see if the dropped stuff is actually made of files could also be good).

on_drag_drop could basically do some checks and the call insert_attachment ( string path ) to add the dropped files to the attachments..

What do you think,postler-developers? =)

[Sergio Spinatelli (spinatelli)]

This works on my machine:

adding this function to the Postler.Composer class

 private void on_drag_drop (Gdk.DragContext context, int x, int y, Gtk.SelectionData data, uint info, uint time_){
        string[] uri= data.get_uris();
  foreach (string s in uri ) {

   File file = File.new_for_uri (s);

   if (file.query_file_type (FileQueryInfoFlags.NOFOLLOW_SYMLINKS) == FileType.REGULAR)
    insert_attachment ( file.get_path ( ) );
  }

  }

and this code to the Composer () constructor:

        Gtk.drag_dest_set ( this, Gtk.DestDefaults.ALL, null, Gdk.DragAction.COPY );
     Gtk.drag_dest_add_uri_targets (this);

     this.drag_data_received.connect (on_drag_drop);

if dropping is allowed in all points of the window.. =)

[Cris Dywan (kalikiana)]

I made a patch based on this suggestion. I went further and made the web view and attachment area destinations, as I think it is confusing to drag for example onto the toolbar. I also added a drag_finish call, passed {} to avoid warnings and added an is_native () check because only local files are supported.